Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: insufficient spacing before footer #33638

Closed
cespare opened this issue Aug 13, 2019 · 1 comment
Closed

x/website: insufficient spacing before footer #33638

cespare opened this issue Aug 13, 2019 · 1 comment

Comments

@cespare
Copy link
Contributor

@cespare cespare commented Aug 13, 2019

The new website's footer could use extra spacing (and/or a visual separator such as a line or a different background color) to differentiate it from the body.

Right now the spacing depends on the preceding element, so it varies from page to page.

For these two pages, the spacing isn't too bad, but I think it's not enough: the footer looks like part of the page content rather than something different.

https://golang.org/pkg/archive/zip/:

screen_20190813142857

https://blog.golang.org/experiment:

screen_20190813142931

On this page, the spacing is more clearly insufficient and the footer crowds into the preceding text:

https://golang.org/pkg/mime/:

screen_20190813142950

I'm using Chrome 76.0.3809.100 on Linux but it looks roughly the same in Firefox and on an Android phone (if I request desktop site). I don't think this is a browser-specific issue.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2019
@andybons andybons added the NeedsFix label Aug 15, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2019

Change https://golang.org/cl/190408 mentions this issue: content/static: apply various stylistic fixes

@golang golang locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.