Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: propagate hoverKind to completion #33653

Closed
inliquid opened this issue Aug 14, 2019 · 1 comment
Closed

x/tools/gopls: propagate hoverKind to completion #33653

inliquid opened this issue Aug 14, 2019 · 1 comment

Comments

@inliquid
Copy link

@inliquid inliquid commented Aug 14, 2019

As per #32561 atm, there is a configuration to provide full docs on hover:

"gopls": {
     "hoverKind": "FullDocumentation",
}

However it's not the case when we want docs on completion:

"gopls": {
    "wantCompletionDocumentation": true,
}

Please make completion return full docs when FullDocumentation option is set or add another config for completion.

@gopherbot gopherbot added this to the Unreleased milestone Aug 14, 2019
@stamblerre stamblerre changed the title x/tools/gopls: add posibility to enable full docs with 'wantCompletionDocumentation' x/tools/gopls: propagate hoverKind to completion, signatureHelp Aug 15, 2019
@stamblerre stamblerre changed the title x/tools/gopls: propagate hoverKind to completion, signatureHelp x/tools/gopls: propagate hoverKind to completion Aug 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 15, 2019

Change https://golang.org/cl/190400 mentions this issue: internal/lsp: propagate hoverKind to completion documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.