Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/dl: UTF-8 source file names differ after unpacking go1.12.9.src.tar.gz #33709

Closed
Sevolin opened this issue Aug 19, 2019 · 3 comments

Comments

@Sevolin
Copy link

commented Aug 19, 2019

What version of Go are you using (go version)?

$ go version
go1.12.9 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN="/home/u1/go/pkg/tool/linux_amd64/"
GOCACHE="/home/u1/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/u1/go/projects"
GOPROXY=""
GORACE=""
GOROOT="/home/u1/go"
GOTMPDIR="/home/u1/go/tmpdir"
GOTOOLDIR="/home/u1/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/home/u1/go/tmpdir/go-build983033821=/tmp/go-build -gno-record-gcc-switches"

What did you do?

In git "https://github.com/golang/go" in dir "test/fixedbugs/issue27836.dir"
the files are called "Äfoo.go" and "Ämain.go".

In website "https://golang.org/dl/" in go1.12.9.src.tar.gz and for previous
versions of GO these files are called "foo.go" and "main.go"

This difference has existed for so long that you can't remember when it started.
And if you unarchieve go1.12.9.src.tar.gz and compile, then an error is generated:

What did you expect to see?

API check

Go version is "go1.12.9", ignoring -next /home/u1/go/api/next.txt

ALL TESTS PASSED

Installed Go for linux/amd64 in /home/u1/go
Installed commands in /home/u1/go/bin
*** You need to add /home/u1/go/bin to your PATH.

What did you see instead?

../test

go run run.go -- fixedbugs/issue27836.go

exit status 1
/home/u1/go/test/fixedbugs/issue27836.dir/main.go:6:2: can't find import: "Äfoo"

FAIL fixedbugs/issue27836.go 0.061s
2019/08/18 22:13:33 Failed: exit status 1

API check

Go version is "go1.12.9", ignoring -next /home/u1/go/api/next.txt
2019/08/18 22:13:34 FAILED

@Sevolin Sevolin closed this Aug 19, 2019
@Sevolin Sevolin reopened this Aug 19, 2019
@Sevolin Sevolin changed the title Go 1.12.9 The difference in test dir of file names in git and golang.org/dl Go 1.12.9 The difference in test dir of file names between git and golang.org/dl Aug 19, 2019
@bcmills

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

The tarball itself appears to contain the correct names for these files:

~/tmp$ curl -O https://dl.google.com/go/go1.12.9.src.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20.9M  100 20.9M    0     0  36.2M      0 --:--:-- --:--:-- --:--:-- 36.2M

~/tmp$ LC_ALL=en_US.UTF-8 tar --list -zf ./go1.12.9.src.tar.gz | grep issue27836
go/test/fixedbugs/issue27836.dir/
go/test/fixedbugs/issue27836.dir/Äfoo.go
go/test/fixedbugs/issue27836.dir/Ämain.go
go/test/fixedbugs/issue27836.go

What exact commands did you run to unpack the tarball, into what kind of filesystem, and with what locale environment variables?

@bcmills bcmills changed the title Go 1.12.9 The difference in test dir of file names between git and golang.org/dl x/dl: UTF-8 source file names differ after unpacking go1.12.9.src.tar.gz Aug 19, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2019
@bcmills

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Note that the Installing Go from source page recommends fetching the repository using git clone rather than downloading the source tarball.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 19, 2019

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.