Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: documents link is not aligned on tip.golang.org/doc/go1.6+ #33718

Closed
JAicewizard opened this issue Aug 19, 2019 · 9 comments
Closed

x/website: documents link is not aligned on tip.golang.org/doc/go1.6+ #33718

JAicewizard opened this issue Aug 19, 2019 · 9 comments

Comments

@JAicewizard
Copy link

@JAicewizard JAicewizard commented Aug 19, 2019

What did you do?

visit one of:
https://tip.golang.org/doc/go1.6
...
https://tip.golang.org/doc/go1.13

What did you expect to see?

see behavior on everything pre go1.6 docs

What did you see instead?

documents_not_aligned

@ALTree
Copy link
Member

@ALTree ALTree commented Aug 19, 2019

Ah, that's funny. In the Go1.5 page and before they're aligned. The issue is caused by an embedded style

<style>
ul li { margin: 0.5em 0; }
</style>

in the .html page, that is present since the Go1.6 release notes.

@ALTree ALTree added NeedsFix and removed Documentation labels Aug 19, 2019
@ALTree ALTree changed the title website: documents link doesnt allign on tip.golang.org/doc/go1.6+ website: documents link is not aligned on tip.golang.org/doc/go1.6+ Aug 19, 2019
@andybons andybons added this to the Unplanned milestone Aug 19, 2019
@tomocy
Copy link
Contributor

@tomocy tomocy commented Aug 19, 2019

Can I tackle on this?

@ALTree
Copy link
Member

@ALTree ALTree commented Aug 19, 2019

@tomocy Sure. If you do, please double-check that my analysis above is correct. I just skimmed the pages sources very quickly.

@JAicewizard
Copy link
Author

@JAicewizard JAicewizard commented Aug 19, 2019

@ALTree FYI that rule is overwritten by line 429 of style.css, so that is not the issue.
If I disable both of the morgin-top rules it works on all pages, but more testing is requred to make sure that its more then just a "works for me" kinda fix.

And in general its weird that ALL other pages work as expected.

@tomocy
Copy link
Contributor

@tomocy tomocy commented Aug 20, 2019

@ALTree I want to modify /lib/godoc/style.css, but I cannot find it. Where is it located??

@agnivade
Copy link
Contributor

@agnivade agnivade commented Aug 20, 2019

https://github.com/golang/website/blob/master/content/static/style.css

EDIT: In general, the title prefix is the package name from the standard library or anything under golang.org. In this case, it is x/website, so golang.org/x/website. That is how you can find which repo holds the code for this issue.

@agnivade agnivade changed the title website: documents link is not aligned on tip.golang.org/doc/go1.6+ x/website: documents link is not aligned on tip.golang.org/doc/go1.6+ Aug 20, 2019
@tomocy
Copy link
Contributor

@tomocy tomocy commented Aug 20, 2019

@agnivade Thank you!! (I did not know website repo)

tomocy added a commit to tomocy/website that referenced this issue Aug 20, 2019
Since the doc of go1.6, the default margin-top of list tag has been 0.5rem not 0 by the embedded style, so assert the same style as the embedded style in stylesheet and re-set the default margin-top to the first of Header-menuItem overwriting the margin-top of it in no media queries.

Fixes golang/go#33718
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 20, 2019

Change https://golang.org/cl/190997 mentions this issue: Fix header item style

@andybons
Copy link
Member

@andybons andybons commented Aug 21, 2019

Duplicate of #33738

@andybons andybons marked this as a duplicate of #33738 Aug 21, 2019
@andybons andybons closed this Aug 21, 2019
@golang golang locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.