Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: do not embed style in release-note HTML files #33738

Open
tomocy opened this issue Aug 20, 2019 · 6 comments

Comments

@tomocy
Copy link
Contributor

commented Aug 20, 2019

When styles are embedded in release note html files, it may also require you to do the same thing in the previous ones to keep the same style across all versions.

The embedded style in go1.6 html seems to cause #33718.

I think that it is better to try not to embed style in release note html files, and write it in stylesheet instead.

@bcmills bcmills changed the title doc: not to embed style in release note html files doc: do not embed style in release-note HTML files Aug 20, 2019

@bcmills

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@bcmills bcmills added this to the Go1.14 milestone Aug 20, 2019

@andybons

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Let's just do this instead of #33718

@gopherbot

This comment has been minimized.

Copy link

commented Aug 21, 2019

Change https://golang.org/cl/191217 mentions this issue: doc: remove embed style in release-note HTML files

gopherbot pushed a commit that referenced this issue Aug 26, 2019
doc: align documents link
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Change https://golang.org/cl/191747 mentions this issue: [release-branch.go1.13] doc: align documents link

@gopherbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Change https://golang.org/cl/191748 mentions this issue: [release-branch.go1.12] doc: align documents link

gopherbot pushed a commit that referenced this issue Aug 26, 2019
[release-branch.go1.12] doc: align documents link
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit cded9f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191748
Reviewed-by: Katie Hockman <katie@golang.org>
gopherbot pushed a commit that referenced this issue Aug 26, 2019
[release-branch.go1.13] doc: align documents link
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit cded9f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191747
Reviewed-by: Katie Hockman <katie@golang.org>
tomocy added a commit to tomocy/go that referenced this issue Sep 1, 2019
doc: align documents link
Updates golang#33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
doc: align documents link
Updates golang#33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Sep 12, 2019

Change https://golang.org/cl/195058 mentions this issue: doc/go1.13: start doc; note end of NaCl platform support

gopherbot pushed a commit that referenced this issue Sep 12, 2019
doc/go1.14: start doc; note end of NaCl platform support
This skeleton follows the model of CL 174521,
with additions from 'relnote -html'.

Updates #33738
Updates #30439

Change-Id: I0f88ff7f231b7728dca0695143f2f2eda74d60c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/195058
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.