Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: skip `darwin-386-10_14` builder on release-branch.go1.12 #33756

Closed
bcmills opened this issue Aug 21, 2019 · 7 comments
Closed

x/build: skip `darwin-386-10_14` builder on release-branch.go1.12 #33756

bcmills opened this issue Aug 21, 2019 · 7 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 21, 2019

As far as I can tell, the darwin-386-10_14 builder was added for #31751 and has been failing for release-branch.go1.12 ever since.

I doubt we'll want to fix a deprecated architecture on an old Go version, so we should skip the builder in that configuration instead.

CC @golang/osp-team

@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2019
@gopherbot gopherbot added the Builders label Aug 21, 2019
@bcmills bcmills added NeedsFix OS-Darwin and removed Builders labels Aug 21, 2019
@gopherbot gopherbot added the Builders label Aug 21, 2019
@bcmills bcmills modified the milestones: Unreleased, Go1.12.10 Aug 21, 2019
@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 21, 2019

I can take a look into this.

@toothrot toothrot self-assigned this Aug 21, 2019
@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 26, 2019

@bcmills Do you think that we should build on >= 1.13, or only master?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Aug 26, 2019

The underlying bug was fixed in 1.13, so this builder should run everything ≥ 1.13.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 26, 2019

Change https://golang.org/cl/191878 mentions this issue: dashboard: require at least Go 1.13 for darwin-386 builder

@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 27, 2019

I will re-deploy the coordinator and build.golang.org to pick up this change.

@FiloSottile FiloSottile modified the milestones: Go1.12.10, Go1.12.11 Sep 25, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Oct 9, 2019

@dmitshur, I notice that this builder is currently showing up in the build dashboard for release-branch.go1.12. I assume that's an expected wart after https://golang.org/cl/199878 (with the fix gated on the app/appengine / cmd/coordinator cleanup)?

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 9, 2019

@bcmills That is correct.

I think it is a low priority enough wart that it can wait a few weeks (compared to the master branch of the main Go repo, I didn't think that could wait as long), but let me know if you think it's more disruptive and should be fixed sooner.

@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
release-branch.go1.12 has failures for darwin-386-10_14, which are fixed
in Go 1.13. darwin-386 is not a first-class port and on a deprecated
architecture for macOS, and can be skipped on older branches.

Fixes golang/go#33756

Change-Id: I5f2e95fe9515978a85b986787d8126655f849629
Reviewed-on: https://go-review.googlesource.com/c/build/+/191878
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.