Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build, runtime: linux-s390x-ibm regression in TestGdbPython on release-branch.go1.12 #33757
Comments
bcmills
changed the title
|
I suspect that the build started failing when I installed GDB on the builder following the merge of https://golang.org/cl/169857 into master. We could cherry-pick that fix I guess. Or disable the test somehow. |
Either of those options seems reasonable to me, assuming the merge is clean. CC @cherrymui |
|
SGTM as well. Thanks. |
bcmills
changed the title
|
This is a fix that addresses an external change that would otherwise make the release unstable with failing tests, so approved the cherry pick. I'll make the CL now. |
|
Change https://golang.org/cl/200039 mentions this issue: |
|
Closed by merging df92229 to release-branch.go1.12. |
On Ubuntu 18.04 I am seeing GDB fail to restore the stack pointer during this test because stack unwinding can't find the PC. This CL is essentially a partial revert of CL 23940 and fixes the issue on s390x. Fixes #33757 Change-Id: Ib4c41162dc85dc882eb6e248330f4082c3fa94c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/169857 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> (cherry picked from commit d91f7e6) Reviewed-on: https://go-review.googlesource.com/c/go/+/200039 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Michael Munday <mike.munday@ibm.com>
TestGdbPython(in theruntimepackage) has been failing on thelinux-s390x-ibmbuilder onrelease-branch.go1.12starting at CL 181658 (https://build.golang.org/log/c9c6830fd79bda38aa4a7c5f1594aafccda247cb).The failure mode appears to be unrelated to that change, so I'm guessing that something about the builder configuration may have changed..?
CC @mundaym @aclements