Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build, runtime: linux-s390x-ibm regression in TestGdbPython on release-branch.go1.12 #33757

Closed
bcmills opened this issue Aug 21, 2019 · 6 comments
Closed

x/build, runtime: linux-s390x-ibm regression in TestGdbPython on release-branch.go1.12 #33757

bcmills opened this issue Aug 21, 2019 · 6 comments
Labels
Builders CherryPickApproved FrozenDueToAge Testing
Milestone
Go1.12.12

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 21, 2019

TestGdbPython (in the runtime package) has been failing on the linux-s390x-ibm builder on release-branch.go1.12 starting at CL 181658 (https://build.golang.org/log/c9c6830fd79bda38aa4a7c5f1594aafccda247cb).

The failure mode appears to be unrelated to that change, so I'm guessing that something about the builder configuration may have changed..?

CC @mundaym @aclements
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2019
@gopherbot gopherbot added the Builders label Aug 21, 2019
@bcmills bcmills added NeedsInvestigation Testing and removed Builders labels Aug 21, 2019
@gopherbot gopherbot added the Builders label Aug 21, 2019
@bcmills bcmills changed the title x/build, runtime: linux-s390x-ibm regression in on release-branch.go1.12 x/build, runtime: linux-s390x-ibm regression on release-branch.go1.12 Aug 21, 2019
@mundaym
Copy link
Member

@mundaym mundaym commented Aug 23, 2019

I suspect that the build started failing when I installed GDB on the builder following the merge of https://golang.org/cl/169857 into master. We could cherry-pick that fix I guess. Or disable the test somehow.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Aug 26, 2019

We could cherry-pick that fix I guess. Or disable the test somehow.

Either of those options seems reasonable to me, assuming the merge is clean.

CC @cherrymui

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Aug 26, 2019

SGTM as well. Thanks.

@bcmills bcmills changed the title x/build, runtime: linux-s390x-ibm regression on release-branch.go1.12 x/build, runtime: linux-s390x-ibm regression in TestGdbPython on release-branch.go1.12 Oct 2, 2019
@bcmills bcmills removed this from the Unreleased milestone Oct 9, 2019
@bcmills bcmills added this to the Go1.12.11 milestone Oct 9, 2019
@bcmills bcmills added the CherryPickCandidate label Oct 9, 2019
@katiehockman katiehockman added CherryPickApproved and removed CherryPickCandidate labels Oct 9, 2019
@katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Oct 9, 2019

This is a fix that addresses an external change that would otherwise make the release unstable with failing tests, so approved the cherry pick. I'll make the CL now.

@katiehockman katiehockman self-assigned this Oct 9, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 9, 2019

Change https://golang.org/cl/200039 mentions this issue: runtime: fix GDB tests on s390x running Ubuntu 18.04

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 9, 2019

Closed by merging df92229 to release-branch.go1.12.

@toothrot toothrot removed the NeedsInvestigation label Oct 9, 2019
gopherbot pushed a commit that referenced this issue Oct 9, 2019
@mundaym @katiehockman
runtime: fix GDB tests on s390x running Ubuntu 18.04
df92229 
On Ubuntu 18.04 I am seeing GDB fail to restore the stack pointer
during this test because stack unwinding can't find the PC. This CL
is essentially a partial revert of CL 23940 and fixes the issue on
s390x.

Fixes #33757

Change-Id: Ib4c41162dc85dc882eb6e248330f4082c3fa94c3
Reviewed-on: https://go-review.googlesource.com/c/go/+/169857
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit d91f7e6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/200039
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
@katiehockman katiehockman removed this from the Go1.12.11 milestone Oct 17, 2019
@katiehockman katiehockman added this to the Go1.12.12 milestone Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders CherryPickApproved FrozenDueToAge Testing
Projects
None yet
Milestone
Go1.12.12
Development

No branches or pull requests
6 participants
@toothrot @bcmills @gopherbot @cherrymui @mundaym @katiehockman