Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: "only supported as of -lang=go1.13" error is misleading [1.13 backport] #33761

Closed
gopherbot opened this issue Aug 21, 2019 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 21, 2019

@ianlancetaylor requested issue #33753 to be considered for backport to the next 1.13 minor release.

@gopherbot please open backport to 1.13

This is an unnecessarily confusing error message for people who want to try the new 1.13 language features, so when we fix it I think we should backport the fix to the 1.13 release series.

@julieqiu

This comment has been minimized.

Copy link

@julieqiu julieqiu commented Sep 2, 2019

Approved according to our policy at https://github.com/golang/go/wiki, since this is a documentation fix.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 16, 2019

Change https://golang.org/cl/201480 mentions this issue: [release-branch.go1.13] cmd/compile: better error message for language version errors

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Oct 16, 2019

Closed by merging 985804b to release-branch.go1.13.

@gopherbot gopherbot closed this Oct 16, 2019
gopherbot pushed a commit that referenced this issue Oct 16, 2019
…e version errors

Fixes #33761.
Updates #33753.
Updates #31747.

Change-Id: Icc42b23405ead4f7f17b0ffa3611405454b6b271
Reviewed-on: https://go-review.googlesource.com/c/go/+/198491
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 27fc32f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/201480
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.