Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: 1.13rc1 docs for TimeoutHandler are incorrect about interfaces #33769
Labels
Milestone
Comments
jmhodges
added a commit
to jmhodges/go
that referenced
this issue
Aug 21, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes golang#33769
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/191237 mentions this issue: |
jmhodges
added a commit
to jmhodges/go
that referenced
this issue
Aug 22, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes golang#33769 Updates golang#29193
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/191169 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Aug 22, 2019
…ch its new interfaces As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes #33769 Updates #29193 Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60 GitHub-Last-Rev: 5310d2c GitHub-Pull-Request: #33770 Reviewed-on: https://go-review.googlesource.com/c/go/+/191237 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit f3e3b71) Reviewed-on: https://go-review.googlesource.com/c/go/+/191169 Reviewed-by: Bryan C. Mills <bcmills@google.com>
t4n6a1ka
added a commit
to t4n6a1ka/go
that referenced
this issue
Sep 5, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes golang#33769 Updates golang#29193 Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60 GitHub-Last-Rev: 5310d2c GitHub-Pull-Request: golang#33770 Reviewed-on: https://go-review.googlesource.com/c/go/+/191237 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of Go 1.13rc1, net/http's TimeoutHandler does implement the Flusher interface that the docs of TimeoutHandler claims it does not. The fact that it does now implement Flusher is mentioned in the release docs for 1.13rc1, though.
TimeoutHandler also now implements Pusher which might be worth a mention in its docs.