Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: 1.13rc1 docs for TimeoutHandler are incorrect about interfaces #33769

Closed
jmhodges opened this issue Aug 21, 2019 · 2 comments
Closed

net/http: 1.13rc1 docs for TimeoutHandler are incorrect about interfaces #33769

jmhodges opened this issue Aug 21, 2019 · 2 comments

Comments

@jmhodges
Copy link
Contributor

@jmhodges jmhodges commented Aug 21, 2019

As of Go 1.13rc1, net/http's TimeoutHandler does implement the Flusher interface that the docs of TimeoutHandler claims it does not. The fact that it does now implement Flusher is mentioned in the release docs for 1.13rc1, though.

TimeoutHandler also now implements Pusher which might be worth a mention in its docs.

jmhodges added a commit to jmhodges/go that referenced this issue Aug 21, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and
this change corrects its documentation to say that.

Fixes golang#33769
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 21, 2019

Change https://golang.org/cl/191237 mentions this issue: net/http: change TimeoutHandler's docs to match its new interfaces

@bcmills bcmills added the NeedsFix label Aug 22, 2019
@bcmills bcmills added this to the Go1.13 milestone Aug 22, 2019
jmhodges added a commit to jmhodges/go that referenced this issue Aug 22, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and
this change corrects its documentation to say that.

Fixes golang#33769
Updates golang#29193
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 22, 2019

Change https://golang.org/cl/191169 mentions this issue: [release-branch.go1.13] net/http: change TimeoutHandler's docs to match its new interfaces

@gopherbot gopherbot closed this in f3e3b71 Aug 22, 2019
gopherbot pushed a commit that referenced this issue Aug 22, 2019
…ch its new interfaces

As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and
this change corrects its documentation to say that.

Fixes #33769
Updates #29193

Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60
GitHub-Last-Rev: 5310d2c
GitHub-Pull-Request: #33770
Reviewed-on: https://go-review.googlesource.com/c/go/+/191237
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit f3e3b71)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191169
Reviewed-by: Bryan C. Mills <bcmills@google.com>
t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and
this change corrects its documentation to say that.

Fixes golang#33769
Updates golang#29193

Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60
GitHub-Last-Rev: 5310d2c
GitHub-Pull-Request: golang#33770
Reviewed-on: https://go-review.googlesource.com/c/go/+/191237
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.