New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh/terminal: file descriptor type is inconvenient #3382

Open
gopherbot opened this Issue Mar 23, 2012 · 6 comments

Comments

Projects
None yet
5 participants
@gopherbot
Copy link

gopherbot commented Mar 23, 2012

by jeff.allen:

What steps will reproduce the problem?
1. write terminal.MakeRaw(os.Stdout.Fd())
2. notice it doesn't compile
3. write terminal.MakeRaw(int(os.Stdout.Fd()))

What is the expected output?

It would be nicer if MakeRaw agreed with Fd() that the type of a file descriptor is
uintptr.

Which revision are you using?  (hg identify)

bce220d03774 weekly/weekly.2012-03-22
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Mar 23, 2012

Comment 1:

Fortunately exp/terminal is not part of Go 1 so we can change the signature, if
appropriate, after the Go 1 release.

Labels changed: added priority-later, packagechange, removed priority-triage.

@robpike

This comment has been minimized.

Copy link
Contributor

robpike commented Mar 25, 2012

Comment 2:

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Nov 27, 2013

Comment 4:

Labels changed: added go1.3maybe.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added release-none, removed go1.3maybe.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-crypto.

@mikioh mikioh changed the title go.crypto/ssh/terminal: file descriptor type is inconvenient ssh/terminal: file descriptor type is inconvenient Jan 7, 2015

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@rsc rsc changed the title ssh/terminal: file descriptor type is inconvenient x/crypto/ssh/terminal: file descriptor type is inconvenient Apr 14, 2015

@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015

@rsc rsc removed the repo-crypto label Apr 14, 2015

@odeke-em

This comment has been minimized.

Copy link
Member

odeke-em commented May 8, 2016

Can we still do this or does it break compatibility for too many programs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment