Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: Example_unwrap fails on windows, js-wasm, nacl #33828

Closed
cuonglm opened this issue Aug 25, 2019 · 6 comments

Comments

@cuonglm
Copy link
Contributor

commented Aug 25, 2019

windows: https://storage.googleapis.com/go-build-log/2dea0128/windows-amd64-2016_91602ff3.log
nacl: https://storage.googleapis.com/go-build-log/2dea0128/nacl-amd64p32_cd2e32e1.log
js-wasm: https://storage.googleapis.com/go-build-log/2dea0128/js-wasm_6c6f1d40.log

--- FAIL: Example_unwrap (0.00s)
got:
reading config file at 1989-03-15 22:30:00 +0000 UTC: open non-existing: The system cannot find the file specified.
want:
reading config file at 1989-03-15 22:30:00 +0000 UTC: open non-existing: no such file or directory
FAIL
FAIL	errors	0.024s
ok  	expvar	0.046s
ok  	flag	0.028s
FAIL
2019/08/25 16:52:31 Failed: exit status 1


Error: tests failed: dist test failed: go_test:errors: exit status 1
@andybons

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

@gopherbot please open a backport issue for 1.13

@gopherbot

This comment was marked as outdated.

Copy link

commented Aug 25, 2019

Backport issue(s) opened: #33829 (for 1.13).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@cuonglm cuonglm changed the title testing: Example_unwrap fails on windows testing: Example_unwrap fails on windows, js-wasm, nacl Aug 25, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Backport issue(s) opened: #33830 (for 1.13).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@cuonglm cuonglm changed the title testing: Example_unwrap fails on windows, js-wasm, nacl errors: Example_unwrap fails on windows, js-wasm, nacl Aug 25, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Change https://golang.org/cl/191541 mentions this issue: errors: fix example unwrap test

@millerresearch

This comment has been minimized.

Copy link

commented Aug 25, 2019

It fails on Plan 9 too.

@dmitshur dmitshur added the Testing label Aug 25, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Change https://golang.org/cl/191742 mentions this issue: Revert "errors: add example showing a custom error with Unwrap"

@gopherbot gopherbot closed this in 78f6856 Aug 26, 2019

t4n6a1ka-github added a commit to t4n6a1ka-github/go that referenced this issue Sep 5, 2019
Revert "errors: add example showing a custom error with Unwrap"
This reverts commit 739123c.

Reason for revert: broke Windows and Plan 9 builders

Fixes golang#33828

Change-Id: I1d85c81549b1b34924fdd0ade8bf9406e5cf6555
Reviewed-on: https://go-review.googlesource.com/c/go/+/191742
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.