Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support workspace/Symbol request #33844

Open
stamblerre opened this issue Aug 26, 2019 · 10 comments
Open

x/tools/gopls: support workspace/Symbol request #33844

stamblerre opened this issue Aug 26, 2019 · 10 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 26, 2019

@gopherbot gopherbot added this to the Unreleased milestone Aug 26, 2019
@gopherbot gopherbot added the gopls label Aug 26, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 26, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@moonnoon

This comment has been minimized.

Copy link

@moonnoon moonnoon commented Sep 3, 2019

helm-lsp needs it.

@stamblerre stamblerre added the Tools label Sep 9, 2019
@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Oct 21, 2019

Just to confirm, workspace/Symbol would effectively allow us to show exported package symbols, correct? Or is the plan to have textDocument/documentSymbol satisfy that question?

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 21, 2019

workspace/Symbol is used to do a search of the workspace on a particular symbol, whereas textDocument/documentSymbol shows the list of symbols in the a given file.

@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Oct 23, 2019

So is there nothing that corresponds to the package level?

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 24, 2019

Not that I am aware of - how would that be displayed by the editor?

@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Oct 24, 2019

In Vim at least I'd imagine doing something like the "Jump to identifier" from godoc:

Screen Shot 2019-10-24 at 09 10 22

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Oct 24, 2019

That does sound like a good feature. I encourage you to open up an issue with LSP :)

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 5, 2020

Change https://golang.org/cl/213317 mentions this issue: internal/lsp: add support for workspace symbol

@daisuzu

This comment has been minimized.

Copy link

@daisuzu daisuzu commented Jan 5, 2020

I sent a change because I'd like to use workspace/symbol with Vim.
This can be used as an alternative to ctags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.