Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: "readSym out of sync" flake #33863

Open
bcmills opened this issue Aug 27, 2019 · 6 comments

Comments

@bcmills
Copy link
Member

commented Aug 27, 2019

Observed in the darwin-amd64-10_14 in https://build.golang.org/log/2c4dfc954904829f5c15825b108b5d21e2108fe4:

# go/token.test
2019/08/26 10:19:55 readSym out of sync
ok  	go/printer	0.213s
ok  	go/scanner	0.013s
FAIL	go/token [build failed]

That line comes from here:

log.Fatalln("readSym out of sync")

@bcmills bcmills added this to the Unplanned milestone Aug 27, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

@cherrymui

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

This looks to me like, if not a memory corruption, the object file is corrupted. Is it possible to retrieve the object file from the builder in case of a failure?

Object file corruption would also explain other flaky linker crashes on the darwin builders. Could it be, by any chance, that the darwin builders' file system is less stable?

@bcmills bcmills added the Builders label Aug 27, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Could it be, by any chance, that the darwin builders' file system is less stable?

Maybe! (CC @bradfitz @toothrot @dmitshur for builder info.)

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

That seems very unlikely.

It's a fresh VMware VM per build, with the VM disk storage on a fancy SSD storage array.

@toothrot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Is it possible that r.readByte() is returning an error in this failure? It looks like we're not logging it, regardless.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Yeah, I'd start with improving the failure message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.