Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sync/syncmap: recommend sync.Map #33867

Closed
bontibon opened this issue Aug 27, 2019 · 3 comments
Closed

x/sync/syncmap: recommend sync.Map #33867

bontibon opened this issue Aug 27, 2019 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix
Milestone

Comments

@bontibon
Copy link
Contributor

@bontibon bontibon commented Aug 27, 2019

The documentation for x/sync/syncmap says:

Package syncmap provides a concurrent map implementation. It is a prototype for a proposed addition to the sync package in the standard library. (https://golang.org/issue/18177)

sync.Map has since been added to the standard library. The documentation should be updated. The syncmap.Map type could be aliases to sync.Map (similar to what was done with x/net/context and context).

@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2019
@bcmills bcmills added help wanted NeedsFix labels Aug 27, 2019
@erutherford
Copy link
Contributor

@erutherford erutherford commented Aug 28, 2019

I'd like to take this on if that's ok.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Aug 28, 2019

@erutherford Sure. Thanks.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 30, 2019

Change https://golang.org/cl/192737 mentions this issue: syncmap: use type alias for Map

@golang golang locked and limited conversation to collaborators Sep 10, 2020
sherifabdlnaby pushed a commit to sherifabdlnaby/sync that referenced this issue Feb 24, 2021
sync.Map was introduced in Go 1.9, this change updates the syncmap package to use a type alias
to sync.Map for 1.9 and later. It also updates the comments to reflect this change.

Fixes golang/go#33867

Change-Id: Ia58ad2bc409f8fcb8a7539ef165148315da5cfb1
Reviewed-on: https://go-review.googlesource.com/c/sync/+/192737
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix
Projects
None yet
Development

No branches or pull requests

5 participants