Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: 'go build' error from 'git ls-remote' when downloading from private repo [1.13 backport] #33880

Closed
gopherbot opened this issue Aug 27, 2019 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 27, 2019

@bcmills requested issue #33836 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 27, 2019

Change https://golang.org/cl/191973 mentions this issue: [release-branch.go1.13] cmd/go/internal/get: remove '--' separator from 'git ls-remote' command

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 27, 2019

Closed by merging 2e3989e to release-branch.go1.13.

@gopherbot gopherbot closed this Aug 27, 2019
gopherbot pushed a commit that referenced this issue Aug 27, 2019
…om 'git ls-remote' command

'git ls-remote' started recognizing the '--' separator at some point
after 2.7.4, but git defaults to version 2.7.4 on Ubuntu 16.04 LTS,
which remains supported by Ubuntu until April 2021.

We added '--' tokens to most VCS commands as a defensive measure in
CL 181237, but it isn't strictly necessary here because the 'scheme'
argument to our template is chosen from a predefined list: we can
safely drop it to retain compatibility.

Cherry-picked from CL 191978.

Updates #33836
Fixes #33880

Change-Id: Ibb53366b95f8029b587e0b7646a439330d759ac7
Reviewed-on: https://go-review.googlesource.com/c/go/+/191973
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.