Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: one new module error is backwards, another seemed backwards [1.13 backport] #33885

Closed
gopherbot opened this issue Aug 27, 2019 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 27, 2019

@bcmills requested issue #33879 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: we should at least fix the reversed error message.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Aug 27, 2019

Change https://golang.org/cl/191972 mentions this issue: [release-branch.go1.13] cmd/go/internal/modload: fix swapped paths in error message

@bcmills bcmills added this to the Go1.13 milestone Aug 27, 2019
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Aug 27, 2019

I'm not sure whether this is severe enough to make the cut.
Making that decision is a release-blocker, but actually cherry-picking the commit probably is not.

gopherbot pushed a commit that referenced this issue Aug 27, 2019
… error message

Cherry-picked from CL 191997.

Updates #33879
Fixes #33885

Change-Id: Ifc91490b1cb791fdf5ffe69ef81c0ec0e6cbecc3
Reviewed-on: https://go-review.googlesource.com/c/go/+/191997
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
(cherry picked from commit 8f5353f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191972
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills removed the NeedsDecision label Aug 27, 2019
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Aug 27, 2019

The fix for the swapped paths has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.