Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: 'IterateBits16': not lowered test failure on 386 linux builders #33902

Closed
ALTree opened this issue Aug 28, 2019 · 7 comments
Closed

cmd/compile: 'IterateBits16': not lowered test failure on 386 linux builders #33902

ALTree opened this issue Aug 28, 2019 · 7 comments

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Aug 28, 2019

All 386 linux builders are currently failing the codegen test suite with this error:

codegen/mathbits.go:354:2: internal compiler error: 'IterateBits16': not lowered: v12, Ctz16NonZero INT UINT16

goroutine 1 [running]:
runtime/debug.Stack(0x8b3bea0, 0xb0680d8, 0x0)
	/workdir/go/src/runtime/debug/stack.go:24 +0x83
cmd/compile/internal/gc.Fatalf(0xb3705c8, 0x8, 0xb00d970, 0x2, 0x2)
	/workdir/go/src/cmd/compile/internal/gc/subr.go:188 +0x26a
cmd/compile/internal/gc.(*ssafn).Fatalf(0xb06a320, 0x2, 0x162021, 0x89928aa, 0x2, 0xb00e900, 0x1, 0x1)
	/workdir/go/src/cmd/compile/internal/gc/ssa.go:6159 +0x14a
cmd/compile/internal/ssa.(*Func).Fatalf(...)
	/workdir/go/src/cmd/compile/internal/ssa/func.go:617
cmd/compile/internal/ssa.checkLower(0xb4671e0)
	/workdir/go/src/cmd/compile/internal/ssa/lower.go:36 +0x301
cmd/compile/internal/ssa.Compile(0xb4671e0)
	/workdir/go/src/cmd/compile/internal/ssa/compile.go:92 +0x865
cmd/compile/internal/gc.buildssa(0xb209b00, 0x0, 0x0)
	/workdir/go/src/cmd/compile/internal/gc/ssa.go:289 +0x9eb
cmd/compile/internal/gc.compileSSA(0xb209b00, 0x0)
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:298 +0x3a
cmd/compile/internal/gc.compile(0xb209b00)
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:277 +0x2c1
cmd/compile/internal/gc.funccompile(0xb209b00)
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:222 +0xad
cmd/compile/internal/gc.Main(0x89bd3b0)
	/workdir/go/src/cmd/compile/internal/gc/main.go:685 +0x2cef
main.main()
	/workdir/go/src/cmd/compile/main.go:51 +0x93


# go run run.go -- codegen/mathbits.go
exit status 2

This appears to be triggered by the optimization merged at CL 189277 (optimize 386's math.bits.TrailingZeros16).

cc @benshi001

@ALTree ALTree changed the title cmd/compile: 'IterateBits16': not lowered on 386 linux builders cmd/compile: 'IterateBits16': not lowered test failure on 386 linux builders Aug 28, 2019
@ALTree ALTree added this to the Go1.14 milestone Aug 28, 2019
@av86743

This comment has been minimized.

Copy link

@av86743 av86743 commented Aug 28, 2019

Similar to #33875?

@ALTree

This comment has been minimized.

Copy link
Member Author

@ALTree ALTree commented Aug 28, 2019

Possibly? : ) The trybots were not run before submitting CL 189277, maybe they would have prevented this.

@av86743

This comment has been minimized.

Copy link

@av86743 av86743 commented Aug 28, 2019

Looks like 2 week delay in the period of active merging brings commit into a danger zone.

@beenshi

This comment has been minimized.

Copy link

@beenshi beenshi commented Aug 28, 2019

Sorry for the trouble, I am working on it.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 28, 2019

Change https://golang.org/cl/192057 mentions this issue: cmd/compile: fix a bug in 386's bits.TrailingZeros

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 28, 2019

Change https://golang.org/cl/192097 mentions this issue: Revert "cmd/compile: optimize 386's math.bits.TrailingZeros16"

gopherbot pushed a commit that referenced this issue Aug 28, 2019
This reverts CL 189277.

Reason for revert: broke 32-bit builders.

Updates #33902

Change-Id: Ie5f180d0371a90e5057ed578c334372e5fc3a286
Reviewed-on: https://go-review.googlesource.com/c/go/+/192097
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Aug 28, 2019

I reverted CL 189277. Please feel free to revert my revert once the fix-forward is reviewed.

The builders appear to be happy again, so closing this issue.

@bcmills bcmills closed this Aug 28, 2019
tomocy added a commit to tomocy/go that referenced this issue Sep 1, 2019
This reverts CL 189277.

Reason for revert: broke 32-bit builders.

Updates golang#33902

Change-Id: Ie5f180d0371a90e5057ed578c334372e5fc3a286
Reviewed-on: https://go-review.googlesource.com/c/go/+/192097
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
This reverts CL 189277.

Reason for revert: broke 32-bit builders.

Updates golang#33902

Change-Id: Ie5f180d0371a90e5057ed578c334372e5fc3a286
Reviewed-on: https://go-review.googlesource.com/c/go/+/192097
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.