net/http: TestTransportCancelRequestInDial failing since CL 185117 #33910
Comments
I have the (trivial) fix ready, but I'm running all tests to ensure no other failures remain. |
Change https://golang.org/cl/192078 mentions this issue: |
tomocy
added a commit
to tomocy/go
that referenced
this issue
Sep 1, 2019
The net/url error in question now quotes the URL, so update the expected output string. While at it, also update a comment in httputil, though that doesn't affect any test. Fixes golang#33910. Change-Id: I0981f528b24337c2952ef60c0db3b7ff72d72110 Reviewed-on: https://go-review.googlesource.com/c/go/+/192078 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka
added a commit
to t4n6a1ka/go
that referenced
this issue
Sep 5, 2019
The net/url error in question now quotes the URL, so update the expected output string. While at it, also update a comment in httputil, though that doesn't affect any test. Fixes golang#33910. Change-Id: I0981f528b24337c2952ef60c0db3b7ff72d72110 Reviewed-on: https://go-review.googlesource.com/c/go/+/192078 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://build.golang.org/log/57ed2a1981079dd230a61ecbec0e7bdfa1e04fb3
The text was updated successfully, but these errors were encountered: