Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cover: cannot run in directory with no .go files [1.13 backport] #33984

Open
gopherbot opened this issue Aug 30, 2019 · 4 comments

Comments

@gopherbot
Copy link

commented Aug 30, 2019

@rhysh requested issue #33855 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13: this is a regression from Go 1.12.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Aug 30, 2019

Change https://golang.org/cl/192722 mentions this issue: [release-branch.go1.13] cmd/cover: skip go list when profile is empty

@andybons andybons added this to the Go1.13.1 milestone Sep 2, 2019

@julieqiu

This comment has been minimized.

Copy link

commented Sep 3, 2019

@rhysh @bcmills would you categorized this as a serious problem with no workaround?

Under our policy at https://github.com/golang/go/wiki/MinorReleases, only fixes for security issues, serious problems with no workaround, and documentation fixes will be backported.

@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

It's a regression from 1.12.

There is a workaround (which is to avoid running go tool cover in a directory that does not contain a Go package). However, the fix CL is also very small and seems low-risk.

@katiehockman

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@andybons commented in the change, but to re-iterate here: let's wait to approve and merge this until 1.13 is out.

This can be added to a point release since it isn't a major issue, even if the fix is small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.