Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support label completions #33987

Closed
muirdm opened this issue Aug 30, 2019 · 2 comments
Closed

x/tools/gopls: support label completions #33987

muirdm opened this issue Aug 30, 2019 · 2 comments
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Aug 30, 2019

Gopls should give label completions for continue, break and goto statements. For example:

Loop:
for i := range foo {
  switch i {
  case 0:
    break <>
  }
}

We should offer the Loop completion when completing at <>.

Labels do not behave like normal identifiers for scoping/shadowing, so some special handling will be required.

@gopherbot gopherbot added this to the Unreleased milestone Aug 30, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 30, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Aug 30, 2019
@stamblerre stamblerre added the Tools label Sep 9, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 26, 2019

Change https://golang.org/cl/197417 mentions this issue: internal/lsp: add label completion candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.