Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: ELF linker won't set .dynsym info when there is no global symbols #34000

Closed
cuonglm opened this issue Sep 1, 2019 · 1 comment
Closed

Comments

@cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Sep 1, 2019

This is follow up issue for #33358

Linker won't set .synsym info field when there's no global symbols, it must set it regardless.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 1, 2019

Change https://golang.org/cl/192600 mentions this issue: cmd/link: always set .dynsym info field

@gopherbot gopherbot closed this in fa7d40a Sep 2, 2019
t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
CL 187979 added set .dynsym info field, but it won't when
there are no global symbols. This CL sets that field
unconditionally.

Fixes golang#34000

Change-Id: Icc2f8bc74afdade88a377793e6760912b03686ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/192600
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.