Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy.golang.org: github.com/go-redis/redis 6.15.4 #34005

Closed
pierrre opened this issue Sep 1, 2019 · 2 comments

Comments

@pierrre
Copy link

commented Sep 1, 2019

What version of Go are you using (go version)?

$ go version

go version go1.13rc2 linux/amd64

Does this issue reproduce with the latest release?

Yes, I'm using the latest RC

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/pierre/.cache/go-build"
GOENV="/home/pierre/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/pierre/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/pierre/.gimme/versions/go1.13rc2.src"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/pierre/.gimme/versions/go1.13rc2.src/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build984822954=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I've noticed that it is impossible for me to get github.com/go-redis/redis 6.15.4.
It prints the error message:

verifying github.com/go-redis/redis@v6.15.4+incompatible/go.mod: github.com/go-redis/redis@v6.15.4+incompatible/go.mod: reading https://sum.golang.org/lookup/github.com/go-redis/redis@v6.15.4+incompatible: 410 Gone

I don't have any issue with version 6.15.3

https://sum.golang.org/lookup/github.com/go-redis/redis@v6.15.3+incompatible is working fine
https://sum.golang.org/lookup/github.com/go-redis/redis@v6.15.4+incompatible is returning an error

Of course, I know that this package is "incompatible" (it seems to be fixed in v7, but it's still in beta).

Do you have any idea why this version is not working ?

I don't see a lot of difference between these versions.
go-redis/redis@v6.15.3...v6.15.4
Could it be caused by the change in go.mod ? (they added go 1.13)

Thank you.

@heschik

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

There's a couple things going on here, I think. First is the new validation added in 1.13, described in the "version validation" section of https://tip.golang.org/doc/go1.13. That would normally reject both v6.15.3+incompatible and .4+incompatible. However, you probably upgraded from 1.12 and already had both versions in your module cache. That bypasses the validation, which only takes place on fetch.

Second is that sum.golang.org was running 1.12 for quite a while, which allowed these bad versions to be recorded permanently in the log. They were purged from proxy.golang.org, so you'll see that both https://proxy.golang.org/github.com/go-redis/redis/@v/v6.15.3+incompatible.info and https://proxy.golang.org/github.com/go-redis/redis/@v/v6.15.4+incompatible.info return the same error as the failing sum.golang.org URL. However, it was not feasible to purge them from sum.golang.org, so the (invalid) cached version will live forever there.

Long and short of it is, these go-redis versions are not usable in module mode in 1.13 without some replace hackery, and you'll get much clearer error messages if you clear your module cache. Hope that clears things up, and sorry for the trouble.

@pierrre

This comment has been minimized.

Copy link
Author

commented Sep 3, 2019

And 6.15.2 is working, because it doesn't have a go.mod file !
I understand now. Thank you for your explanation. 👍

I will open an issue to go-redis, and mention this current issue.
(Originally, I thought it was an issue with the proxy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.