Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: autocomplete in comments #34010

Open
stamblerre opened this issue Sep 1, 2019 · 4 comments

Comments

@stamblerre
Copy link
Contributor

commented Sep 1, 2019

Suggest the name of the symbol when writing the beginning of a comment for an exported symbol. For example:

// <>
var Foo int 

The above should offer a completion for Foo.

@gopherbot gopherbot added this to the Unreleased milestone Sep 1, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Sep 1, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Sep 1, 2019

@stamblerre stamblerre added help wanted NeedsFix and removed gopls labels Sep 1, 2019

@gopherbot gopherbot added the gopls label Sep 1, 2019

@KarthikNayak

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

I want to pick this up, but I'm not familiar with the gopls codebase, so might take some time.

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@KarthikNayak: The first place to look would be in https://github.com/golang/tools/blob/be0da057c5e3c2df569a2c25cd280149b7d7e7d0/internal/lsp/source/completion.go#L441. I would suggest making a separate function for autocompletion in comments and going from there. Feel free to reach out to me here or on the Gophers Slack if you have any questions on how to move forward with this.

@KarthikNayak

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

@stamblerre Thanks for the heads up. I'll contact you if I need any clarifications!

@stamblerre stamblerre added the Tools label Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.