Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: does not check go:writebarrierrec for print functions #34014

Open
ianlancetaylor opened this issue Sep 2, 2019 · 0 comments

Comments

@ianlancetaylor
Copy link
Contributor

commented Sep 2, 2019

The runtime function sighandler is marked go:nowritebarrierrec. It calls print which cmd/compile turns into calls to printstring and friends. However, if I modify printstring to force a write barrier, no error is issued when compiling the runtime package. If I then mark printstring as go:nowritebarrierrec, I do get an error. My conclusion from this is that cmd/compile does not apply go:nowritebarrierrec to the calls generated by calling the print function.

I believe this is because in (*nowritebarrierrecChecker).check the printstring functions are never added to the symToFunc map.

CC @aclements

@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.