-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: "go list -m all" hangs for git.apache.org #34016
Comments
Thrift has officially switched to to github with v0.12.0, which was released last year. We've supported cloning from |
The problem still persist if other required modules still require I can’t tell anymore but I believe deleting the modules cache manually finally did the trick (while keeping the replace statement). |
thanks, |
go list -m all
hangs for git.apache.org
I'm not able to reproduce a hang. I do see a long delay during the direct-mode fetch, but it eventually resolves to a useful error message. @ukai, is there something in your global Git config that would prevent Both runs starting from a clean module cache:
|
Change https://golang.org/cl/193039 mentions this issue: |
Change https://golang.org/cl/193097 mentions this issue: |
The older versions impose transitive dependencies on git.apache.org/thrift.git, which has since been removed. Commands run: go get -d google.golang.org/api go.opencensus.io go mod tidy go test ./... Updates golang/go#34016 Change-Id: I32f4926cac55d630febd9d4a4412eeb99ed9878e Reviewed-on: https://go-review.googlesource.com/c/website/+/193039 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
Change https://golang.org/cl/193098 mentions this issue: |
This removes the transitive dependency on git.apache.org/thrift.git, dropped from x/website in CL 193039. Commands run: go get -d golang.org/x/website@00e97558e113808bd2e87edf2275d97515bad94b go mod tidy go test ./... Updates golang/go#34016 Change-Id: I903f1eb29454db1c76945bea97a77d5748913c8c Reviewed-on: https://go-review.googlesource.com/c/blog/+/193098 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
As far as I can tell there is nothing more to be done here. As @ukai notes, you can use a You can figure out “whatever depends on it” using For the
|
Also, I plan on including a |
@dcelasun, adding a ( |
@bcmills sorry my comment was a bit tangential, just wanted to mention it after seeing that |
golangci-lint breaks because go list fails due to `thrift` package issue; see: golang/go#34016 and later due to another issue golangci/golangci-lint#658 for which a release of golangci-lint is yet to be made. This patch fixes these by moving to operator-sdk version 0.10 and by installing (go get) latest golangci-lint Signed-off-by: Sunil Thaha <sthaha@redhat.com>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
with warmed go module cache, it is not problem.
It doesn't require git.apache.org/thrift.git module.
e.g.
go list -m all
doesn't showgit.apache.org/thrift.git
norgo mod why git.apache.org/thrift.git
show 'not need package'.in go.sum,
was written.
(probably go.opencensus.io v0.18.0?)
go mod tidy
won't clear this entry.What did you expect to see?
go list -m all
didn't hang.What did you see instead?
go list -m all
hangs to try to check git.apache.org/thrift.gitif used with new go module cache.
adding
replace git.apache.org/thrift.git => github.com/apache/thrift v0.12.0
could fix this.The text was updated successfully, but these errors were encountered: