Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/imports: test frequently times out on `dragonfly-amd64` builder #34034

Open
bcmills opened this issue Sep 3, 2019 · 3 comments
Open

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Sep 3, 2019

The test for golang.org/x/tools/internal/imports seems to be timing out on around 25% of runs on the dragonfly-amd64 builder.

Example logs:

The dragonfly-amd64 builder seems to be a bit underpowered in general (see also #29583 and #25796). Perhaps we should set GO_TEST_TIMEOUT_SCALE=2 in its environment and see if that improves the situation for x/tools?

CC @matloob @ianthehat @tdfbsd

@tdfbsd

This comment has been minimized.

Copy link

@tdfbsd tdfbsd commented Sep 3, 2019

The builder is on a dedicated machine with a Core I5-6600 cpu and 16GB RAM.

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Sep 3, 2019

Hrm. That seems like it should be a good enough machine to run those tests without timing out.

All of the timeouts seem to involve either filesystem operations or go command invocations (which themselves involve many filesystem operations). Is it possible that the builder has high disk contention?

@tdfbsd

This comment has been minimized.

Copy link

@tdfbsd tdfbsd commented Sep 3, 2019

The other processes on this machine are very light duty. The only thing that could cause serious filesystem contention is the nightly hammer cleanup process that typically runs around 10am UTC.

These failures feel "racy" to me, in part because they aren't consistent. DragonFly has gone to great lengths in the past year to improve SMP performance and I'm wondering if maybe they removed one lock too many. I have no clue how to troubleshoot that.

@stamblerre stamblerre added the Tools label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.