Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add builder for netbsd/arm64 #34036

Open
bcmills opened this issue Sep 3, 2019 · 10 comments
Open

x/build: add builder for netbsd/arm64 #34036

bcmills opened this issue Sep 3, 2019 · 10 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Sep 3, 2019

The Go 1.13 release notes currently claim that “Go now supports NetBSD on arm64.”

We have a host-netbsd-arm-bsiegert builder, but it isn't clear to me whether that is regular ARM or ARM64.

By last report (#30824 (comment)), the netbsd/arm64 build may be broken.

We should either get a netbsd/arm64 builder up and running and verify that it is passing, or remove the claim of support from the release notes.

CC @bsiegert @bradfitz @ianlancetaylor @andybons @toothrot @dmitshur

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 3, 2019

Change https://golang.org/cl/192997 mentions this issue: doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD

@bcmills bcmills removed the Soon label Sep 3, 2019
gopherbot pushed a commit that referenced this issue Sep 3, 2019
Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates #30824
Updates #31656
Updates #34035
Updates #34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 3, 2019

Change https://golang.org/cl/192998 mentions this issue: [release-branch.go1.13] doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD

gopherbot pushed a commit that referenced this issue Sep 3, 2019
…port on NetBSD and OpenBSD

Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates #30824
Updates #31656
Updates #34035
Updates #34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 9f5127b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/192998
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@bsiegert
Copy link
Contributor

@bsiegert bsiegert commented Sep 3, 2019

Sorry that this was not clearer. We do not, as a matter of fact, have a netbsd/arm64 builder. The netbsd-arm-bsiegert is arm, as the name says. Right now, binaries compiled on netbsd/arm64 die when they receive a signal, so we cannot sensibly run the go tool on it. Rest assured that I'll take care of a builder when we are at that point.

For now, removing arm64 from the release notes SGTM.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Sep 3, 2019

Thanks for the confirmation!

@bcmills bcmills changed the title x/build: unclear whether we have builders for netbsd/arm64 x/build: add builder for netbsd/arm64 Sep 3, 2019
t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates golang#30824
Updates golang#31656
Updates golang#34035
Updates golang#34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
havoc-io added a commit to mutagen-io/mutagen that referenced this issue Jul 12, 2020
While Go will build for these platforms, neither currently has a builder
and netbsd/arm64 is apparently broken. It looks like the Go 1.13 release
notes were updated to remove the announcement of these ports. Support
for netbsd/arm64 is tracked in golang/go#34036 and support for
openbsd/arm64 is tracked in golang/go#34035.

Signed-off-by: Jacob Howard <jacob@havoc.io>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 16, 2020

@bsiegert I saw your recent message on golang-dev. Let's use this as the tracking issue for the next steps. I can send you a builder key soon (on Monday).

/cc @cagedmantis Issue #36841 may be relevant here. Please let us know if you think it would be viable to have a non-reverse builder for NetBSD ARM64. I think we can proceed with a reverse builder for now, but if a non-reserve builder becomes possible/easy in the future, let's evaluate that option too.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 17, 2020

I've provided a builder key to @bsiegert. Benny, please update this issue and/or ping me when you're ready to take the next steps here.

@dmitshur dmitshur removed their assignment Aug 17, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 17, 2020

@bsiegert @dmitshur a non-reverse builder for NetBSD ARM64 is on the roadmap for the near future (next few weeks). There is no need to delay this any further by waiting for that builder to go online.

@bsiegert
Copy link
Contributor

@bsiegert bsiegert commented Aug 18, 2020

@cagedmantis I am excited to hear about the non-reverse arm64 builder! There does not need to be any waiting involved; we can have both builders for the time being, and I'll happily decommission the reverse builder.

@dmitshur provided a key, and I have the builder running right now. I will send a CL to add it to the coordinator.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 18, 2020

Change https://golang.org/cl/249137 mentions this issue: dashboard: add netbsd-arm64-bsiegert builder (reverse)

gopherbot pushed a commit to golang/build that referenced this issue Aug 18, 2020
Update golang/go#34036

Change-Id: Ic92093e764fa163d97a2f125a4534581adf217da
Reviewed-on: https://go-review.googlesource.com/c/build/+/249137
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bsiegert
Copy link
Contributor

@bsiegert bsiegert commented Sep 30, 2020

@cagedmantis How is the non-reverse builder coming along? Anything I can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants