Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add builder for netbsd/arm64 #34036

Open
bcmills opened this issue Sep 3, 2019 · 4 comments

Comments

@bcmills
Copy link
Member

commented Sep 3, 2019

The Go 1.13 release notes currently claim that “Go now supports NetBSD on arm64.”

We have a host-netbsd-arm-bsiegert builder, but it isn't clear to me whether that is regular ARM or ARM64.

By last report (#30824 (comment)), the netbsd/arm64 build may be broken.

We should either get a netbsd/arm64 builder up and running and verify that it is passing, or remove the claim of support from the release notes.

CC @bsiegert @bradfitz @ianlancetaylor @andybons @toothrot @dmitshur

@gopherbot

This comment has been minimized.

Copy link

commented Sep 3, 2019

Change https://golang.org/cl/192997 mentions this issue: doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD

@bcmills bcmills removed the Soon label Sep 3, 2019

gopherbot pushed a commit that referenced this issue Sep 3, 2019
doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD
Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates #30824
Updates #31656
Updates #34035
Updates #34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Sep 3, 2019

Change https://golang.org/cl/192998 mentions this issue: [release-branch.go1.13] doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD

gopherbot pushed a commit that referenced this issue Sep 3, 2019
[release-branch.go1.13] doc/go1.13: remove announcements of arm64 sup…
…port on NetBSD and OpenBSD

Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates #30824
Updates #31656
Updates #34035
Updates #34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 9f5127b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/192998
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@bsiegert

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Sorry that this was not clearer. We do not, as a matter of fact, have a netbsd/arm64 builder. The netbsd-arm-bsiegert is arm, as the name says. Right now, binaries compiled on netbsd/arm64 die when they receive a signal, so we cannot sensibly run the go tool on it. Rest assured that I'll take care of a builder when we are at that point.

For now, removing arm64 from the release notes SGTM.

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Thanks for the confirmation!

@bcmills bcmills changed the title x/build: unclear whether we have builders for netbsd/arm64 x/build: add builder for netbsd/arm64 Sep 3, 2019

t4n6a1ka added a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
doc/go1.13: remove announcements of arm64 support on NetBSD and OpenBSD
Those configurations currently lack builders, and it is not clear to
me what state their tests are in.

The Go porting policy¹ requires builders for all active ports, so
let's not claim support until that requirement is met.

¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port

Updates golang#30824
Updates golang#31656
Updates golang#34035
Updates golang#34036

Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b
Reviewed-on: https://go-review.googlesource.com/c/go/+/192997
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.