Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get panics in GOPATH mode on custom import path with an insecure redirect [1.13 backport] #34081

Closed
gopherbot opened this issue Sep 4, 2019 · 3 comments

Comments

@gopherbot
Copy link

commented Sep 4, 2019

@bcmills requested issue #34049 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13. This panic makes insecure redirects much harder to diagnose, and the fix is trivial.

@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 4, 2019

@bcmills bcmills self-assigned this Sep 4, 2019

@bcmills bcmills changed the title cmd/go: go get fails in GOPATH mode on custom import path with a redirect [1.13 backport] cmd/go: go get panics in GOPATH mode on custom import path with an insecure redirect [1.13 backport] Sep 4, 2019

@gopherbot

This comment has been minimized.

Copy link
Author

commented Sep 4, 2019

Change https://golang.org/cl/193264 mentions this issue: [release-branch.go1.13] cmd/go/internal/get: avoid panic in metaImportsForPrefix if web.Get fails

@dmitshur

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Approving. The provided rationale meets the backporting criteria.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Closed by merging 052d7c8 to release-branch.go1.13.

@gopherbot gopherbot closed this Sep 11, 2019

gopherbot pushed a commit that referenced this issue Sep 11, 2019
[release-branch.go1.13] cmd/go/internal/get: avoid panic in metaImpor…
…tsForPrefix if web.Get fails

Updates #29591
Updates #34049
Fixes #34081

Change-Id: I817b83ee2d0ca6d01ec64998f14bc4f32e365d66
Reviewed-on: https://go-review.googlesource.com/c/go/+/193259
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 1eab1aa6ba6c3f4d6f084751bca9a065707c3085)
Reviewed-on: https://go-review.googlesource.com/c/go/+/193264
Reviewed-by: Jay Conrod <jayconrod@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.