Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "found, but does not contain package" error refers to replaced version instead of its replacement [1.13 backport] #34118

Closed
gopherbot opened this issue Sep 5, 2019 · 2 comments
Assignees
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 5, 2019

@bcmills requested issue #34085 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: this produces very confusing error messages, and the fix is small.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Sep 25, 2019

Change https://golang.org/cl/197317 mentions this issue: [release-branch.go1.13] cmd/go/internal/modload: annotate replacements in PackageNotInModuleError

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Sep 26, 2019

Closed by merging 4b1d9c4 to release-branch.go1.13.

@gopherbot gopherbot closed this Sep 26, 2019
gopherbot pushed a commit that referenced this issue Sep 26, 2019
…s in PackageNotInModuleError

Updates #34085
Fixes #34118

Change-Id: I3111f5997466ad33f51e80c71f5fb2ccebdcc6e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/193617
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 8189a06)
Reviewed-on: https://go-review.googlesource.com/c/go/+/197317
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.