Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: Duplicate symbols with more than one main package in -coverpkg [1.13 backport] #34223

Open
gopherbot opened this issue Sep 10, 2019 · 4 comments

Comments

@gopherbot
Copy link

commented Sep 10, 2019

@FiloSottile requested issue #34114 to be considered for backport to the next 1.13 minor release.

@gopherbot please open a backport issue for Go 1.13, this looks like a possible regression without a workaround.

/cc @bcmills @jayconrod

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

This issue has a similar root cause to #30907, but this affects GOPATH builds. The fix for #30907 (cherry-picked to 1.12) was too narrow and didn't cover GOPATH builds. There is no simple workaround, and the fix is low risk.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Sep 13, 2019

Change https://golang.org/cl/195281 mentions this issue: [release-branch.go1.13] cmd/go: fix link error for -coverpkg in GOPATH mode

@FiloSottile

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

@jayconrod Does this also affect Go 1.12?

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

No, I don't think so. The original repro steps don't work on 1.12, and the modified test passes without the fix.

I believe there were some changes to the linker in 1.13 that made it stricter about this kind of thing. The root cause of this issue is present in 1.12, but it doesn't seem to cause an error. So probably not worth cherry-picking there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.