Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/coordinator: the "Go 1.12.x" suffix for trybots sometimes disappears #34234
Trybots test on non-main repos by running on go tip and we have 2 builders that test the 2 current releases (1.13.x and 1.12.x). Those builders are supposed to have a suffix in the title so people can tell them apart, e.g.:
I've noticed some trybot reports do not include the "Go 1.12.x" suffix in some occasions. For example:
Note it says:
The second "linux-amd64" line should've been "linux-amd64 (Go 1.12.x)" because commit 61a5d11 is on 1.12 release branch, not
I've seen it happen to my own trybot run just now:
Note that it says "linux-amd64 rev cf06b9aa", which is clearly a 1.12.x commit.
I think I have a lead where to start the investigation.
It seems to happen when a trybot builder is restarted due to a communication error. Specifically, I saw the "linux-amd64 (Go 1.12.x)" builder get a "failed to get a buildlet in 5 minutes" failure, and when it restarted, it said "linux-amd64" without the suffix.
The name is computed in
So the issue is likely that the