Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: the "Go 1.12.x" suffix for trybots sometimes disappears #34234

Open
dmitshur opened this issue Sep 11, 2019 · 1 comment

Comments

@dmitshur
Copy link
Member

commented Sep 11, 2019

Trybots test on non-main repos by running on go tip and we have 2 builders that test the 2 current releases (1.13.x and 1.12.x). Those builders are supposed to have a suffix in the title so people can tell them apart, e.g.:

linux-amd64
linux-amd64 (Go 1.13.x)
linux-amd64 (Go 1.12.x)

I've noticed some trybot reports do not include the "Go 1.12.x" suffix in some occasions. For example:

https://go-review.googlesource.com/c/tools/+/191018/5#message-3523913181223269365a639f2de619f97c9748b8

Note it says:

2 of 10 TryBots failed:
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/83bd8812/linux-amd64_473638fb.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/61a5d114/linux-amd64_e368aff8.log

The second "linux-amd64" line should've been "linux-amd64 (Go 1.12.x)" because commit 61a5d11 is on 1.12 release branch, not master.

/cc @bradfitz @toothrot

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I've seen it happen to my own trybot run just now:


image

Note that it says "linux-amd64 rev cf06b9aa", which is clearly a 1.12.x commit.

I think I have a lead where to start the investigation.

It seems to happen when a trybot builder is restarted due to a communication error. Specifically, I saw the "linux-amd64 (Go 1.12.x)" builder get a "failed to get a buildlet in 5 minutes" failure, and when it restarted, it said "linux-amd64" without the suffix.

The name is computed in buildStatus.NameAndBranch method, which looks correct.

So the issue is likely that the goBranch isn't set (or maybe the NameAndBranch method isn't called) when a trybot builder is restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.