Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add tests for configuration options #34244

Closed
stamblerre opened this issue Sep 11, 2019 · 5 comments
Closed

x/tools/gopls: add tests for configuration options #34244

stamblerre opened this issue Sep 11, 2019 · 5 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 11, 2019

We recently had a regression in the configuration options.
We should add tests to ensure that these options are applied correctly.

@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
@andream16
Copy link

@andream16 andream16 commented Nov 3, 2019

Hi @stamblerre , I would like to work on this. Can you be more specific? What should be tested?

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 4, 2019

The options are configured in https://github.com/golang/tools/blob/master/internal/lsp/source/options.go, and I think the way to test them would be by testing the different settings for features like "HoverKind" and "ExperimentalDisabledAnalyses". The options are modified through the tests (see here and here), but they could also be modified in the internal/lsp/cmd tests.

@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 4, 2019
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 May 21, 2020
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
msAlcantara added a commit to msAlcantara/tools that referenced this issue Dec 13, 2020
Added some tests to hoverKind, matcher, env and directoryFilters
of configuration options.

Fixes golang/go#34244
@msAlcantara
Copy link

@msAlcantara msAlcantara commented Dec 13, 2020

Hi @stamblerre , I created some tests for configuration options, but the current documentation of contributing seems to be incomplete, and I would like to know if I can just send a PR on this repository on Github. Could you help me?

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Dec 14, 2020

Awesome, thanks for doing that, @msAlcantara! You can absolutely send a PR--take a look at the instructions here: https://golang.org/doc/contribute.html, specifically https://golang.org/doc/contribute.html#sending_a_change_github.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 14, 2020

Change https://golang.org/cl/278072 mentions this issue: internal/lsp: Add tests to set configuration options

msAlcantara added a commit to msAlcantara/tools that referenced this issue Dec 17, 2020
Added some tests to hoverKind, matcher, env and directoryFilters
of configuration options.

Fixes golang/go#34244
msAlcantara added a commit to msAlcantara/tools that referenced this issue Dec 23, 2020
Added some tests to hoverKind, matcher, env and directoryFilters
of configuration options.

Fixes golang/go#34244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.