Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/build: ImportDir accepts directories that don't exist #3428

Open
4ad opened this issue Mar 29, 2012 · 22 comments

Comments

@4ad
Copy link
Member

commented Mar 29, 2012

What steps will reproduce the problem?

http://play.golang.org/p/P1R9-ON7KU

What is the expected output?

Some sort of error.

What do you see instead?

An incomplete build.Package describing something that doesn't exist.

Which compiler are you using (5g, 6g, 8g, gccgo)?

gc

Which version are you using?  (run 'go version')

go1
@rsc

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2012

Comment 1:

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @rsc.

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2012

Comment 2:

Labels changed: added go1.1.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2012

Comment 4:

Labels changed: added size-m.

@adg

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2013

Comment 5:

https://golang.org/cl/7129048

Owner changed to @adg.

Status changed to Started.

@adg

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2013

Comment 6:

This issue was closed by revision 9413a6f.

Status changed to Fixed.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2013

Comment 7:

I am not sure this is a bug at all. The fix broke godoc net/http so I have disabled it
in CL 7235052.

Status changed to Thinking.

@adg

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2013

Comment 8:

Let my try and address the godoc stuff (issue #4330) without this fix, then we'll see if
the behavior should change.
In the meantime I'll remove the cruft from go/build, as the real fix may be something
different and more subtle.
@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2013

Comment 9:

Labels changed: added priority-later, removed priority-soon.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2013

Comment 10:

Still not sure this is a bug at all, but it's definitely not a Go 1.1 bug anymore. Too
late to be making changes like this.

Labels changed: added go1.2, removed go1.1.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2013

Comment 11:

Labels changed: added feature.

@robpike

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2013

Comment 12:

Removing the Go 1.2 tag. I believe the fix is right but godoc's internals depend on this
in subtle and mysterious ways. Once godoc is cleaned up we have a chance of sorting this
out. Until then, no can do.

Labels changed: removed go1.2.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2013

Comment 13:

Labels changed: added go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2013

Comment 14:

Labels changed: added release-go1.3, removed go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2013

Comment 15:

Labels changed: added repo-main.

@rsc

This comment has been minimized.

Copy link
Contributor

commented May 9, 2014

Comment 16:

Labels changed: added release-none, removed release-go1.3.

@4ad 4ad assigned adg May 9, 2014

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

@odeke-em

This comment has been minimized.

Copy link
Member

commented May 7, 2016

So I've reapplied @adg's previously reverted fix in 9413a6f on tip 9d7c9b4.

and all the net/* tests pass. I don't have trybot running access so can't test it out more via a CL. Should we be taking a look at this more or is this low priority?

Am at

$ git log | head -n 1
commit 9d7c9b4384db01afd2acb27d3a4636b60e957f08
$ go version
go version devel +9d7c9b4 Sat May 7 08:00:39 2016 +0000 darwin/amd64
@odeke-em

This comment has been minimized.

Copy link
Member

commented May 7, 2016

Okay I've run them all on my computer and can confirm that all the tests pass with @adg's previous fix at least on

$ uname -a
Darwin Emmanuels-MacBook-Pro-2.local 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb 26 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASE_X86_64 x86_64

Would you like me to send a CL or would you @adg like to do the honours since it is your fix?

@adg

This comment has been minimized.

Copy link
Contributor

commented May 10, 2016

@odeke-em pleas send a CL.

@adg

This comment has been minimized.

Copy link
Contributor

commented May 10, 2016

@odeke-em does godoc work, though?

@odeke-em

This comment has been minimized.

Copy link
Member

commented May 11, 2016

Aye aye, let me get this in then, thanks. Yes godoc works, please see this gist https://gist.github.com/odeke-em/0fe427ceabb2296fae37c5b0c61b433f.

@odeke-em

This comment has been minimized.

Copy link
Member

commented May 11, 2016

@gopherbot

This comment has been minimized.

Copy link

commented May 11, 2016

CL https://golang.org/cl/23013 mentions this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.