Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: run full codegen testsuite (-all_codegen) on amd64 trybots #34297
In 4f248e9 (CL 177577), @rsc introduced
Unfortunately, none of the trybots has been updated to use
Codegen bugs are hairy, often affect multiple platforms, and are hard to detect. The codegen testsuite was explicitly design to cross-compile by default as the only way for compiler developers to catch those bugs.
Disabling it in
My proposal is to run
AFAIK @dmitshur and @bradfitz own the trybots and the builders; but as long as you don't make them too slow (IIRC the goal is to have them return a result within 5 minutes) I don't think they will have anything against adding a new check to one of them.
So the question is: how fast the linux-amd64-ssacheck trybot is? And if you add -all_codegen, it'll be still faster than the currently slowest trybot? If yes, adding the flag won't slow down the trybots overall, so it should be fine.
EDIT: looks like we have a decision : )