Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: output a DW_LNE_end_sequence instruction at the end of every function's line table #34380

Open
jeremyfaller opened this issue Sep 18, 2019 · 1 comment

Comments

@jeremyfaller
Copy link
Contributor

commented Sep 18, 2019

As we move DWARF generation out of the linker and into the compiler, we've taken some short cuts when emitting the line table. Specifically, rather than outputting a DW_LNE_end_sequence at the end of every function's debug_lines table, we reset the state machine. See discussion HERE.

We are blocked on Delve supporting multiple DW_LNE_end_sequences per compilation unit. See Delve's issue HERE.

In addition to making the state machine mechanics simpler, we can remove the assert in the linker that PCs are monotonically increasing per functions in a compilation unit. Again, see the discussion.

@jeremyfaller jeremyfaller self-assigned this Sep 18, 2019
@jeremyfaller

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

CC: @aarzilli

@jeremyfaller jeremyfaller changed the title cmd/compile: output a DW_LNE_end_sequence instruction at the end of every function's line table unti cmd/compile: output a DW_LNE_end_sequence instruction at the end of every function's line table unit Sep 18, 2019
@jeremyfaller jeremyfaller changed the title cmd/compile: output a DW_LNE_end_sequence instruction at the end of every function's line table unit cmd/compile: output a DW_LNE_end_sequence instruction at the end of every function's line table Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.