net/url: Parse does not parse username and password correctly

[snaury]

If you do something like:

u, _ := url.Parse("http://user@gmail.com:password@hostname.com:80/path";)

Then u.User.Username() would be "user" and u.Host would be
"gmail.com:password@hostname.com:80". This is unexpected and contrary to other
languages and frameworks. Instead of splitting on the first "@" in authority,
url.Parse should split on the last.

[gopherbot]

Comment 1 by stephen@q5comm.com:

I submitted a CL.
http://golang.org/cl/5975050/

[remyoudompheng]

Comment 2:

See RFC3986, section 3.2.1 for the expected format and section 2.3 for the list of
unreserved characters. Your URL is invalid.
By the way, to submit a CL, you should send it on the mailing-lint by running "hg mail"
as explained on http://golang.org/doc/contribute.html Otherwise it's invisible.

[snaury]

Comment 3:

I know it's technically invalid, still that's what lots of url parsers too. One big
example is Google Chrome, which makes request to hostname.com/path, and not something
else. I would be ok if url.Parse returned an error in a case like that, btw. It's just
splitting on the last "@" in authority is a lot easier.

[dsymonds]

Comment 4:

Yes, I think net/url should either clearly reject that URL, or parse it like other URL
parsers.
Full example: http://play.golang.org/p/ijPqsLnvtl

Labels changed: added priority-soon, packagebug, removed priority-triage.

Status changed to Accepted.

[snaury]

Comment 5:

I submitted a new CL at http://golang.org/cl/6206090, since a small change
requested by rsc was not done by stephen for 1.5 months already.

[rsc]

Comment 6:

This issue was closed by revision f7277da.

Status changed to Fixed.