Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/cmd/golangorg, x/build/cmd/tip: inconsistent tabwidth value #34448

Closed
dmitshur opened this issue Sep 21, 2019 · 4 comments
Closed

x/website/cmd/golangorg, x/build/cmd/tip: inconsistent tabwidth value #34448

dmitshur opened this issue Sep 21, 2019 · 4 comments
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 21, 2019

https://tip.golang.org uses the default godoc presentation tab width of 4, but https://golang.org uses a tab width of 8 (because it's being overridden in appinit.go). This results in inconsistent rendering.

https://tip.golang.org/pkg/runtime/debug/#GCStats:

image

https://golang.org/pkg/runtime/debug/#GCStats:

image

They should use the same value. We need to decide which.

/cc @andybons @julieqiu

@dmitshur dmitshur added this to the Unreleased milestone Sep 21, 2019
@dmitshur dmitshur self-assigned this Sep 21, 2019
@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Sep 21, 2019

I would prefer going with 4 everywhere, because 8 is quite wide, and 4 seems more commonly used. The future discovery site (issue #33654) and godoc.org currently use a tab width of 4:

https://godoc.org/runtime/debug#GCStats:

image

But I also realize this is a subjective preference.

@andybons
Copy link
Member

@andybons andybons commented Sep 22, 2019

4 is fine

@andybons andybons added NeedsFix and removed NeedsDecision labels Sep 22, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 23, 2019

Change https://golang.org/cl/196937 mentions this issue: cmd/golangorg: change tab width from 8 to 4 in production

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Sep 23, 2019

This fix is deployed.

@golang golang locked and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.