Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/packages: return information on missing imports #34484

Open
stamblerre opened this issue Sep 24, 2019 · 1 comment
Open

go/packages: return information on missing imports #34484

stamblerre opened this issue Sep 24, 2019 · 1 comment
Labels

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 24, 2019

gopls currently has some handling for packages that were imported but not found by go/packages. This is something that go/packages could return more effectively, either through its errors or through an additional field.

@stamblerre stamblerre added the NeedsFix label Sep 24, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 24, 2019

Change https://golang.org/cl/196985 mentions this issue: internal/lsp: remove missing imports handling

gopherbot pushed a commit to golang/tools that referenced this issue Sep 25, 2019
This change uses the missing imports detection to return diagnostics and
warning messages to the user.

Updates golang/go#34484

Change-Id: If7bb7e702b8bdbd7e1ad5e26f93acc50d16209b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/196985
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.