Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Connection to HTTP/2 site with IdleConnTimeout hangs [1.13 backport] #34498

Closed
gopherbot opened this issue Sep 24, 2019 · 4 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 24, 2019

@bradfitz requested issue #34387 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13.

(I'm assuming.)

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Sep 25, 2019

In #34387 (comment), @fraenkel notes:

It's a regression. It is a bit difficult to come up with a good set of tests to cover the connection management between the http and http2 side.

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Sep 25, 2019

@fraenkel, if you would like this to be backported, please send a cherry-pick CL per https://github.com/golang/go/wiki/MinorReleases#making-cherry-pick-cls.

(On the other hand, if you don't think it's a good backport candidate after all, please let us know or close this issue.)

@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Sep 26, 2019

Change https://golang.org/cl/197377 mentions this issue: [release-branch.go1.13] net/http: remove http2 connections when no longer cached

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Sep 26, 2019

Closed by merging 44a4250 to release-branch.go1.13.

@gopherbot gopherbot closed this Sep 26, 2019
gopherbot pushed a commit that referenced this issue Sep 26, 2019
…nger cached

When the http2 transport returns a NoCachedConnError, the connection
must be removed from the idle list as well as the connections per host.

Fixes #34498

Change-Id: I7875c9c95e694a37a339bb04385243b49f9b20d3
Reviewed-on: https://go-review.googlesource.com/c/go/+/196665
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/197377
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.