Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add "slowbots" support #34501

Open
bradfitz opened this issue Sep 24, 2019 · 7 comments

Comments

@bradfitz
Copy link
Member

commented Sep 24, 2019

We aim to make TryBots be only 5 minutes, but sometimes people want long, deeper tests over all architectures.

We've heard from the compiler/runtime team (@martisch, et al) that a more broad TryBot mode would be useful.

I thought we had a bug for this already but can't find it. (Maybe it was a comment on another bug)

The plan I thought writing about elsewhere was that when clicking "+1 TryBot", you could write some magic syntax in the comment field on Gerrit to specify which extra bots run. Some other tool can help you construct that magic comment & do the Gerrit comment for you, like git-codereview does (when you specify git-codereview mail -trybot)

@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2019
@gopherbot gopherbot added the Builders label Sep 24, 2019
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

Related:

  • #9858: x/build: trybots should rebase when testing Builders
  • #12482 x/build: optional auto-submit on +2 when trybots (with rebase) pass
@martisch

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Related:

  • #29239 x/build: trybots should include all platforms that can contribute release-blockers
@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Also related:

@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Heh, @bradfitz used the term “SlowBots” in #29239 (comment) too.

@eliasnaur

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

This would be fantastic for testing changes on the slow and difficult to set up mobile devices. It would have helped avoid the 4 part fix https://go-review.googlesource.com/c/go/+/193847/

@andybons

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Maybe we fold this into an umbrella issue for a Commit Queue that would cover a lot of the issues above?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2019

Let's not. They're different enough and I was actually working on this one last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.