Skip to content

x/build: add "slowbots" support #34501

Closed
Closed

Description

@bradfitz

We aim to make TryBots be only 5 minutes, but sometimes people want long, deeper tests over all architectures.

We've heard from the compiler/runtime team (@martisch, et al) that a more broad TryBot mode would be useful.

I thought we had a bug for this already but can't find it. (Maybe it was a comment on another bug)

The plan I thought writing about elsewhere was that when clicking "+1 TryBot", you could write some magic syntax in the comment field on Gerrit to specify which extra bots run. Some other tool can help you construct that magic comment & do the Gerrit comment for you, like git-codereview does (when you specify git-codereview mail -trybot)

Activity

  1. added
    FeatureRequestIssues asking for a new feature that does not need a proposal.
    on Sep 24, 2019
  2. added this to the Unreleased milestone on Sep 24, 2019
  3. added
    Buildersx/build issues (builders, bots, dashboards)
    on Sep 24, 2019
  4. bradfitz commented on Sep 24, 2019

    @bradfitz
    ContributorAuthor

    Related:

  5. martisch commented on Sep 24, 2019

    @martisch
    Contributor

    Related:

  6. bcmills commented on Sep 24, 2019

    @bcmills
    Contributor
  7. bcmills commented on Sep 24, 2019

    @bcmills
    Contributor

    Heh, @bradfitz used the term “SlowBots” in #29239 (comment) too.

  8. added
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Sep 26, 2019
  9. eliasnaur commented on Sep 26, 2019

    @eliasnaur
    Contributor

    This would be fantastic for testing changes on the slow and difficult to set up mobile devices. It would have helped avoid the 4 part fix https://go-review.googlesource.com/c/go/+/193847/

  10. andybons commented on Oct 1, 2019

    @andybons
    Member

    Maybe we fold this into an umbrella issue for a Commit Queue that would cover a lot of the issues above?

  11. bradfitz commented on Oct 1, 2019

    @bradfitz
    ContributorAuthor

    Let's not. They're different enough and I was actually working on this one last week.

  12. gopherbot commented on Oct 15, 2019

    @gopherbot
    Contributor

    Change https://golang.org/cl/201204 mentions this issue: maintner/maintnerd: return TRY= comment directives in Run-TryBot votes

  13. gopherbot commented on Oct 16, 2019

    @gopherbot
    Contributor

    Change https://golang.org/cl/201338 mentions this issue: cmd/coordinator: add SlowBots support, opt-in to different slow trybots

  14. bradfitz commented on Oct 16, 2019

    @bradfitz
    ContributorAuthor
  15. 19 remaining items

  16. bradfitz commented on Nov 20, 2019

    @bradfitz
    ContributorAuthor

    Talking to myself,

    TRY=* doesn't sound right. And using a placeholder like _ for "any" like TRY=*-_ is cryptic.

    I suppose ? is a better globby pattern instead of _.

    So TRY=*-? would mean all OSes on any (the best relevant) architecture.

    Too cryptic?

    TRY=geese would be cuter.

  17. gopherbot commented on Apr 9, 2020

    @gopherbot
    Contributor

    Change https://golang.org/cl/227778 mentions this issue: cmd/coordinator: consider explicitly requested builders as SlowBots

  18. dmitshur commented on Apr 9, 2020

    @dmitshur
    Member

    In order to resolve #38279 and make SlowBots more predictable, I am considering changing them slightly so that whenever a builder is explicitly requested via the TRY= syntax, it is always considered a SlowBot.

    Previously, if a builder was explicitly requested via TRY= but also was a part of the default trybot set for a given CL, then it wasn't considered to be a SlowBot. So it was possible to write TRY=linux-amd64 and see "TryBots are starting ..." instead of "SlowBots are starting ...".

    I've sent CL 227778 for review that implements this change. Please let me know if there's any feedback.

  19. gopherbot commented on Apr 9, 2020

    @gopherbot
    Contributor

    Change https://golang.org/cl/227780 mentions this issue: cmd/coordinator: consider explicitly requested builders as SlowBots

  20. gopherbot commented on Apr 9, 2020

    @gopherbot
    Contributor

    Change https://golang.org/cl/227779 mentions this issue: cmd/coordinator, dashboard: don't skip cmd/dist tests for SlowBots

  21. randall77 commented on Jun 17, 2020

    @randall77
    Contributor

    Slowbots seem to be stickier than I imagined. See CL 238077. I requested a slowbot early on in development. I'd now like to run the normal trybot set, but it seems to still be picking up my original slowbot request, even though that request is now several patch sets in the past.

  22. dmitshur commented on Aug 18, 2020

    @dmitshur
    Member

    @randall77 That is intended behavior, documented at https://golang.org/wiki/SlowBots:

    When running TryBots again later, the most recent TRY= comment on the current patchset is used. To turn it off set TRY= with an empty string after the equals sign. If the current patchset doesn't have a TRY= comment, the most recent non-empty TRY= comment is used.

    If you already know that and would like to suggest a change, please open a separate issue about it.

  23. added
    NeedsFixThe path to resolution is known, but the work has not been done.
    and removed
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Aug 18, 2020
  24. dmitshur commented on Aug 18, 2020

    @dmitshur
    Member

    I'm going to close this high level tracking issue as done.

    By now, SlowBots are widely available and very useful for development purposes. We intend to continue to support them (or an alternative mechanism that provides equivalent functionality) as long as they're deemed useful, and we'll continue to improve them over time together with the rest of the build infrastructure. For all remaining bugs and usability improvements related to SlowBots, please open new issues with "x/build/cmd/coordinator:" prefix and SlowBots in the title.

    Thank you @bradfitz and everyone else who contributed to making SlowBots a reality!

  25. locked and limited conversation to collaborators on Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions