You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We aim to make TryBots be only 5 minutes, but sometimes people want long, deeper tests over all architectures.
We've heard from the compiler/runtime team (@martisch, et al) that a more broad TryBot mode would be useful.
I thought we had a bug for this already but can't find it. (Maybe it was a comment on another bug)
The plan I thought writing about elsewhere was that when clicking "+1 TryBot", you could write some magic syntax in the comment field on Gerrit to specify which extra bots run. Some other tool can help you construct that magic comment & do the Gerrit comment for you, like git-codereview does (when you specify git-codereview mail -trybot)
Reacted by Martisch, Tobias Klauser, Than McIntosh and Dmitri Shuralyov
In order to resolve #38279 and make SlowBots more predictable, I am considering changing them slightly so that whenever a builder is explicitly requested via the TRY= syntax, it is always considered a SlowBot.
Previously, if a builder was explicitly requested via TRY= but also was a part of the default trybot set for a given CL, then it wasn't considered to be a SlowBot. So it was possible to write TRY=linux-amd64 and see "TryBots are starting ..." instead of "SlowBots are starting ...".
I've sent CL 227778 for review that implements this change. Please let me know if there's any feedback.
Slowbots seem to be stickier than I imagined. See CL 238077. I requested a slowbot early on in development. I'd now like to run the normal trybot set, but it seems to still be picking up my original slowbot request, even though that request is now several patch sets in the past.
When running TryBots again later, the most recent TRY= comment on the current patchset is used. To turn it off set TRY= with an empty string after the equals sign. If the current patchset doesn't have a TRY= comment, the most recent non-empty TRY= comment is used.
If you already know that and would like to suggest a change, please open a separate issue about it.
I'm going to close this high level tracking issue as done.
By now, SlowBots are widely available and very useful for development purposes. We intend to continue to support them (or an alternative mechanism that provides equivalent functionality) as long as they're deemed useful, and we'll continue to improve them over time together with the rest of the build infrastructure. For all remaining bugs and usability improvements related to SlowBots, please open new issues with "x/build/cmd/coordinator:" prefix and SlowBots in the title.
Thank you @bradfitz and everyone else who contributed to making SlowBots a reality!
Activity
bradfitz commentedon Sep 24, 2019
Related:
martisch commentedon Sep 24, 2019
Related:
bcmills commentedon Sep 24, 2019
Also related:
bcmills commentedon Sep 24, 2019
Heh, @bradfitz used the term “SlowBots” in #29239 (comment) too.
eliasnaur commentedon Sep 26, 2019
This would be fantastic for testing changes on the slow and difficult to set up mobile devices. It would have helped avoid the 4 part fix https://go-review.googlesource.com/c/go/+/193847/
andybons commentedon Oct 1, 2019
Maybe we fold this into an umbrella issue for a Commit Queue that would cover a lot of the issues above?
bradfitz commentedon Oct 1, 2019
Let's not. They're different enough and I was actually working on this one last week.
gopherbot commentedon Oct 15, 2019
Change https://golang.org/cl/201204 mentions this issue:
maintner/maintnerd: return TRY= comment directives in Run-TryBot votesmaintner/maintnerd: return TRY= comment directives in Run-TryBot votes
gopherbot commentedon Oct 16, 2019
Change https://golang.org/cl/201338 mentions this issue:
cmd/coordinator: add SlowBots support, opt-in to different slow trybotsbradfitz commentedon Oct 16, 2019
It's alive! (on https://go-review.googlesource.com/c/go/+/171822/22#message-1627ac4750a897104245e2dc87cc20f838c0b057)
/cc @ianlancetaylor
19 remaining items
bradfitz commentedon Nov 20, 2019
Talking to myself,
I suppose
?is a better globby pattern instead of_.So
TRY=*-?would mean all OSes on any (the best relevant) architecture.Too cryptic?
TRY=geesewould be cuter.gopherbot commentedon Apr 9, 2020
Change https://golang.org/cl/227778 mentions this issue:
cmd/coordinator: consider explicitly requested builders as SlowBotsdmitshur commentedon Apr 9, 2020
In order to resolve #38279 and make SlowBots more predictable, I am considering changing them slightly so that whenever a builder is explicitly requested via the TRY= syntax, it is always considered a SlowBot.
Previously, if a builder was explicitly requested via TRY= but also was a part of the default trybot set for a given CL, then it wasn't considered to be a SlowBot. So it was possible to write
TRY=linux-amd64and see "TryBots are starting ..." instead of "SlowBots are starting ...".I've sent CL 227778 for review that implements this change. Please let me know if there's any feedback.
gopherbot commentedon Apr 9, 2020
Change https://golang.org/cl/227780 mentions this issue:
cmd/coordinator: consider explicitly requested builders as SlowBotscmd/coordinator: consider explicitly requested builders as SlowBots
gopherbot commentedon Apr 9, 2020
Change https://golang.org/cl/227779 mentions this issue:
cmd/coordinator, dashboard: don't skip cmd/dist tests for SlowBotscmd/coordinator, dashboard: don't skip cmd/dist tests for SlowBots
randall77 commentedon Jun 17, 2020
Slowbots seem to be stickier than I imagined. See CL 238077. I requested a slowbot early on in development. I'd now like to run the normal trybot set, but it seems to still be picking up my original slowbot request, even though that request is now several patch sets in the past.
dmitshur commentedon Aug 18, 2020
@randall77 That is intended behavior, documented at https://golang.org/wiki/SlowBots:
If you already know that and would like to suggest a change, please open a separate issue about it.
dmitshur commentedon Aug 18, 2020
I'm going to close this high level tracking issue as done.
By now, SlowBots are widely available and very useful for development purposes. We intend to continue to support them (or an alternative mechanism that provides equivalent functionality) as long as they're deemed useful, and we'll continue to improve them over time together with the rest of the build infrastructure. For all remaining bugs and usability improvements related to SlowBots, please open new issues with "x/build/cmd/coordinator:" prefix and SlowBots in the title.
Thank you @bradfitz and everyone else who contributed to making SlowBots a reality!