Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/tip: false positive in health check #34526
I just noticed on farmer.golang.org that there is an error in tip status monitoring. As of now, https://farmer.golang.org/status/tip says:
Thanks for reporting.
I've looked into this and it seems to be a false positive in the health check. The https://tip.golang.org website is currently deployed at the correct version and functioning properly. So the problem is with the health check, not tip.golang.org. I'll update the issue accordingly.
I'll copy more debug information here, since the false positive might go away:
https://tip.golang.org/_tipstatus currently reports:
Set the working directory in the Dockerfile to be inside the golang.org/x/build module before running go install on cmd/tip. Otherwise, it just installs the latest cmd/tip from the internet rather than the intended local version. (All other Dockerfiles in x/build had this line, except cmd/tip.) Remove duplicate and unneeded WORKDIR instruction from two other Dockerfiles to improve consistency. Fix a rare race condition setting p.err when os.MkdirAll fails. Add a log message when a new server has been started successfully and the side switches. This will make logs easier to read. Fixes golang/go#34526 Updates golang/go#34192 Change-Id: Iab8124f5c872fb87844e8e2f9b31637ce395f11b Reviewed-on: https://go-review.googlesource.com/c/build/+/197302 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Benny Siegert <email@example.com>