Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/tip: false positive in health check #34526

Closed
bsiegert opened this issue Sep 25, 2019 · 3 comments
Closed

x/build/cmd/tip: false positive in health check #34526

bsiegert opened this issue Sep 25, 2019 · 3 comments
Assignees
Milestone

Comments

@bsiegert
Copy link
Contributor

@bsiegert bsiegert commented Sep 25, 2019

I just noticed on farmer.golang.org that there is an error in tip status monitoring. As of now, https://farmer.golang.org/status/tip says:

# "tip" status: tip.golang.org website
# Notes: https://github.com/golang/build/tree/master/cmd/tip
Error: _tipstatus page reports error: builder.Init: checkout of go: reset: fatal: Could not parse object 'a3426f2571bc6f6e55f70ad7a0e7198ecdeb10e4'.

/cc @adg

@gopherbot gopherbot added this to the Unreleased milestone Sep 25, 2019
@gopherbot gopherbot added the Builders label Sep 25, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 25, 2019

Thanks for reporting.

I've looked into this and it seems to be a false positive in the health check. The https://tip.golang.org website is currently deployed at the correct version and functioning properly. So the problem is with the health check, not tip.golang.org. I'll update the issue accordingly.

I'll copy more debug information here, since the false positive might go away:

https://tip.golang.org/_tipstatus currently reports:

side=b
current=go=0f7b4e72/website=a9a9c92a
error=builder.Init: checkout of go: reset: fatal: Could not parse object 'a3426f2571bc6f6e55f70ad7a0e7198ecdeb10e4'.

exit status 128
uptime=3797110
@dmitshur dmitshur changed the title x/build: error on https://farmer.golang.org/status/tip x/build/cmd/tip: false positive in health check Sep 25, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 26, 2019

I've found the root cause. This was a fun one. :)

@dmitshur dmitshur self-assigned this Sep 26, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 26, 2019

Change https://golang.org/cl/197302 mentions this issue: cmd/tip: don't install cmd/tip from the internet

codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Set the working directory in the Dockerfile to be inside the
golang.org/x/build module before running go install on cmd/tip.
Otherwise, it just installs the latest cmd/tip from the internet
rather than the intended local version. (All other Dockerfiles
in x/build had this line, except cmd/tip.)

Remove duplicate and unneeded WORKDIR instruction from two other
Dockerfiles to improve consistency.

Fix a rare race condition setting p.err when os.MkdirAll fails.

Add a log message when a new server has been started successfully
and the side switches. This will make logs easier to read.

Fixes golang/go#34526
Updates golang/go#34192

Change-Id: Iab8124f5c872fb87844e8e2f9b31637ce395f11b
Reviewed-on: https://go-review.googlesource.com/c/build/+/197302
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
@golang golang locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.