Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/tip: no longer shows version number in footer #34531

Open
bradfitz opened this issue Sep 25, 2019 · 5 comments
Open

x/build/cmd/tip: no longer shows version number in footer #34531

bradfitz opened this issue Sep 25, 2019 · 5 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Sep 25, 2019

https://tip.golang.org/ used to show version info in its footer:

http://web.archive.org/web/20180403104659/https://tip.golang.org/

We lost that in the redesign.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Sep 25, 2019
@gopherbot gopherbot added the Builders label Sep 25, 2019
@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Sep 25, 2019

What's the value of having it there? To ensure that it's actually at tip?

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Sep 25, 2019

Yes, whether it's at tip, but also to see where it's at for local repros of things. So you can git reset to that exact spot.

Also, it broadcasts to other readers that this is an ugly/debug/temporary version.

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented Sep 25, 2019

Gotcha. So to be clear. Only show it on tip as it’s useful for debugging. Thanks for the context.

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Sep 26, 2019

I'm not against showing the version in the footer on https://tip.golang.org more visually. However, there are other ways of getting this information.

So you can git reset to that exact spot.

For this purpose, the /_tipstatus endpoint is more useful, because it shows the commit of Go and x/website. Both are important if one cares about knowing the exact version of the website that was deployed.

Additionally, the version information is still a part of the website source:

 $ curl -s 'https://tip.golang.org/' | grep goVersion
<script>var goVersion = "devel +225f484 Wed Sep 25 23:27:16 2019 +0000";</script>

Finally, godoc.org used to scape the version from the footer, and had to be updated when the footer changed. See CL 193258. (It's only relevant once every 6 months when a major Go release is made, so it wasn't worth making a bigger change.)

@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Sep 26, 2019

For this purpose, the /_tipstatus endpoint is more useful,

I wrote that handler and I can't remember its URL.

I'd still like it to be human-visible. Perhaps it could even link to /_tipstatus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.