Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/tip: installs x/website/cmd/golangorg from internet instead of the cloned commit #34545
That is quite silly; it shouldn't do that.
(It's not very harmful because the intention of
I spotted this problem after debugging issue #34526 and then seeing the following in cmd/tip production logs:
This is deployed and I can confirm the fix worked.
Note these lines are no longer there:
It's only downloading dependencies now, which is the intended behavior.
The 'go install golang.org/x/website/cmd/golangorg' command is being configured with GO111MODULE=on and GOPROXY=https://proxy.golang.org environment variables, but its directory was not set. As a result, the main module was an empty module (GOMOD=/dev/null) instead of the module in the website repository that was just checked out. Set the working directory of the go install command to websiteDir, so that the intended website module is used during the build. Fixes golang/go#34545 Change-Id: If51030494ddb90a63b9d198209a04c5fb328784e Reviewed-on: https://go-review.googlesource.com/c/build/+/197397 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>