Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: make.bash broken on dwarf (on linux-mips64le builder) #34549

Closed
ALTree opened this issue Sep 26, 2019 · 4 comments
Closed

cmd/compile: make.bash broken on dwarf (on linux-mips64le builder) #34549

ALTree opened this issue Sep 26, 2019 · 4 comments
Labels
Milestone

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Sep 26, 2019

The linux-mips64le-mengzhuo builder (and only that one) is currently broken, make.bash failing with:

# cmd/internal/obj
src/cmd/internal/obj/dwarf.go:57:18: cannot use dctxt (type dwCtxt) as type dwarf.Context in argument to dwarf.Uleb128put:
	dwCtxt does not implement dwarf.Context (wrong type for AddFileRef method)
		have AddFileRef(dwarf.Sym, interface {})
		want AddFileRef(dwarf.Sym, interface {})
src/cmd/internal/obj/dwarf.go:80:20: cannot use dctxt (type dwCtxt) as type dwarf.Context in argument to dwarf.Uleb128put:
	dwCtxt does not implement dwarf.Context (wrong type for AddFileRef method)
		have AddFileRef(dwarf.Sym, interface {})
		want AddFileRef(dwarf.Sym, interface {})

[...]
go tool dist: FAILED: /tmp/workdir-host-linux-mipsle-mengzhuo/go/pkg/tool/linux_mips64le/go_bootstrap install -gcflags=all= -ldflags=all= -a -i cmd/asm cmd/cgo cmd/compile cmd/link: exit status 2

Full log: https://build.golang.org/log/0d42c095b6c4f9ffc05afce41409fae19ba917eb

The failure started at 78baea8 (internal/bytealg: add assembly implementation of Compare / CompareString on mips64x), which seems unrelated.

cc @mengzhuo as builder owner and author of that commit
cc @jeremyfaller @aclements for runtime and dwarf

@ALTree ALTree added this to the Go1.14 milestone Sep 26, 2019
@mengzhuo

This comment has been minimized.

Copy link
Contributor

@mengzhuo mengzhuo commented Sep 26, 2019

My bad.
Will look into it.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 26, 2019

Change https://golang.org/cl/197557 mentions this issue: internal/bytealg: fix mips64x wrong compare implement

@ALTree ALTree added NeedsFix and removed NeedsInvestigation labels Sep 28, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 2, 2019

Change https://golang.org/cl/198358 mentions this issue: bytes: add endian base compare test

@mdempsky

This comment has been minimized.

Copy link
Member

@mdempsky mdempsky commented Oct 3, 2019

Seems like this was fixed?

@gopherbot gopherbot closed this in a1b1ba7 Oct 3, 2019
gopherbot pushed a commit that referenced this issue Oct 7, 2019
The current bytes test suit didn't come with endian based test
which causing #34549 can passed the try-bot.
This test will failed when little endian architecture simply using
load and compare uint.

Update #34549

Change-Id: I0973c2cd505ce21c2bed1deeb7d526f1e872118d
Reviewed-on: https://go-review.googlesource.com/c/go/+/198358
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.