net/http: Flush in TimeoutHandler for Go1.13 is broken and might need a revert [1.13 backport] #34560
Labels
Milestone
Comments
In #34439 (comment), @pam4 notes:
In #34439 (comment), @bradfitz replies:
|
Based on the above, approving for Go 1.13.2. |
Change https://golang.org/cl/197543 mentions this issue: |
Closed by merging de96471 to release-branch.go1.13. |
gopherbot
pushed a commit
that referenced
this issue
Sep 27, 2019
…ler.Flush Also added a test to ensure that any interactions between TimeoutHandler and Flusher result in the correct status code and body, but also that we don't get superfluous logs from stray writes as was seen in the bug report. Fixes #34560. Change-Id: I4af62db256742326f9353f98a2fcb5f71d2a5fd9 Reviewed-on: https://go-review.googlesource.com/c/go/+/197659 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 4faf8a8) Reviewed-on: https://go-review.googlesource.com/c/go/+/197543
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@bcmills requested issue #34439 to be considered for backport to the next 1.13 minor release.
The text was updated successfully, but these errors were encountered: