Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net/http: TestTimeoutHandlerAndFlusher flaky on darwin-arm64-corellium #34573
The new regression test added for #34439 just flaked twice on the
(Also, I have no idea why the test server thinks it is a teapot.
Thanks for the ping Bryan! That test tests out the TimeoutHandler which requires an actual timeout/sleep, not just synchronization. I think perhaps the sleep duration might have been too short. Also it reports that it is a teapot because that's the status code that was purposefully set :) I'll take a look at it when I get to the office in a few hours, am currently out running many early morning errands, thanks for the assignment.…
On Fri, Sep 27, 2019 at 7:59 AM Bryan C. Mills ***@***.***> wrote: Assigned #34573 <#34573> to @odeke-em <https://github.com/odeke-em>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#34573?email_source=notifications&email_token=ABFL3V32P4UY7HI5SOB4AE3QLYNUDA5CNFSM4I3HPC42YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT4KQ4CQ#event-2668957194>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFL3VZZTRMFY2MC77FZCETQLYNUDANCNFSM4I3HPC4Q> .
Going nuclear SGTM but let's perhaps figure out how to catch such failures if anyone ever makes such a subtle change to TimeoutHandler.…
On Fri, Sep 27, 2019 at 8:06 AM Brad Fitzpatrick ***@***.***> wrote: Let's just delete the whole test. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#34573?email_source=notifications&email_token=ABFL3V72VMV367PZLCKCWLDQLYOQPA5CNFSM4I3HPC42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZGAEY#issuecomment-535978003>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFL3VZ5FN2G4QUDTIWRHO3QLYOQPANCNFSM4I3HPC4Q> .
… due to flakes Removes TestTimeoutHandlerAndFlusher due to flakes on one of the builders due to timing issues. Perhaps later, we might need to bring it back when we've figured out the timing issues. Updates #34573 Fixes #34579 Change-Id: Ia88d4da31fb228296144dc31f9a4288167fb4a53 Reviewed-on: https://go-review.googlesource.com/c/go/+/197757 Run-TryBot: Emmanuel Odeke <firstname.lastname@example.org> Reviewed-by: Bryan C. Mills <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> (cherry picked from commit 5573885) Reviewed-on: https://go-review.googlesource.com/c/go/+/197719 Run-TryBot: Bryan C. Mills <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Emmanuel Odeke <email@example.com>
@odeke-em, there were different failure modes:
(In all cases the underlying
Anyway, if everything except
Thanks for fixing the issue, btw!