Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: missing test output in case of timeouts #34576

Closed
bcmills opened this issue Sep 27, 2019 · 2 comments
Closed

x/build: missing test output in case of timeouts #34576

bcmills opened this issue Sep 27, 2019 · 2 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Sep 27, 2019

The test log at https://build.golang.org/log/5f3ee279eff750a1e1fbb46a5866d993c36ca7a0 ends with the following output:

##### 
Test "go_test:net" ran over 20m0s limit (20m0.036448368s)

That seems to imply that the test has deadlocked, but in order to diagnose the deadlock we need the goroutine dump, which is not present.

It is not obvious to me whether the lack of goroutine dump is a bug in the builder/buildlet sharding and logging path, in cmd/dist, or in the runtime.

Probably we should start the investigation with the builders.

CC @bradfitz @toothrot @dmitshur

@bcmills
Copy link
Member Author

@bcmills bcmills commented Sep 30, 2019

The examples of this sort of output seem to be numerous. I'm not sure when they started appearing.

Here's another one from over the weekend: https://build.golang.org/log/9ec791ff66e9d9d62b6f45049c0934552a176110

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 21, 2019

Change https://golang.org/cl/202477 mentions this issue: cmd/coordinator: include command output in timeout failures

codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Fixes golang/go#34576

Change-Id: I77d85c311612bdbdcff665051659c2609a0af760
Reviewed-on: https://go-review.googlesource.com/c/build/+/202477
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.