Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTimeoutHandlerAndFlusher flaky on darwin-arm64-corellium [1.13 backport] #34579

Closed
gopherbot opened this issue Sep 27, 2019 · 2 comments
Closed

net/http: TestTimeoutHandlerAndFlusher flaky on darwin-arm64-corellium [1.13 backport] #34579

gopherbot opened this issue Sep 27, 2019 · 2 comments
Labels
CherryPickApproved
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 27, 2019

@bcmills requested issue #34573 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13: the flaky test was also backported.
@gopherbot gopherbot mentioned this issue Sep 27, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Sep 27, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Sep 27, 2019

Change https://golang.org/cl/197719 mentions this issue: [release-branch.go1.13] net/http: remove TestTimeoutHandlerAndFlusher due to flakes
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Sep 27, 2019

Closed by merging 0c07603 to release-branch.go1.13.
@gopherbot gopherbot closed this Sep 27, 2019
gopherbot pushed a commit that referenced this issue Sep 27, 2019
@odeke-em @bcmills
[release-branch.go1.13] net/http: remove TestTimeoutHandlerAndFlusher…
0c07603 
… due to flakes

Removes TestTimeoutHandlerAndFlusher due to flakes on
one of the builders due to timing issues.

Perhaps later, we might need to bring it back when we've
figured out the timing issues.

Updates #34573
Fixes #34579

Change-Id: Ia88d4da31fb228296144dc31f9a4288167fb4a53
Reviewed-on: https://go-review.googlesource.com/c/go/+/197757
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 5573885)
Reviewed-on: https://go-review.googlesource.com/c/go/+/197719
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
  Go1.13.3
3 participants
@gopherbot @bcmills @katiehockman
You can’t perform that action at this time.