Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: unified diff tests don't handle multi file patches #34580

Open
ianthehat opened this issue Sep 27, 2019 · 1 comment
Open

x/tools/gopls: unified diff tests don't handle multi file patches #34580

ianthehat opened this issue Sep 27, 2019 · 1 comment

Comments

@ianthehat
Copy link

@ianthehat ianthehat commented Sep 27, 2019

we test unified diff output by attempting to apply the patch and seeing if we get the right result, we do this because the actual content of the patch does not matter and may vary, only the results of applying it can be verified to be correct.
because the only way to apply a multi-file patch is to modify the original files, we cannot easily do this in a test (single file mode writes to a different file instead)
we need to consider attempting to copy the files to a temporary directory to apply the patches to test this.

@gopherbot gopherbot added this to the Unreleased milestone Sep 27, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 27, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
@stamblerre stamblerre added the Testing label Jan 13, 2020
@stamblerre stamblerre modified the milestones: gopls unplanned, gopls testing Jan 29, 2020
@stamblerre stamblerre added this to the Unreleased milestone Jan 29, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.