ianthehat opened this issue
Sep 27, 2019
· 1 comment
Labels
goplsIssues related to the Go language server, gopls.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.
we test unified diff output by attempting to apply the patch and seeing if we get the right result, we do this because the actual content of the patch does not matter and may vary, only the results of applying it can be verified to be correct.
because the only way to apply a multi-file patch is to modify the original files, we cannot easily do this in a test (single file mode writes to a different file instead)
we need to consider attempting to copy the files to a temporary directory to apply the patches to test this.
The text was updated successfully, but these errors were encountered:
gopherbot
added
Tools
This label describes issues relating to any tools in the x/tools repository.
gopls
Issues related to the Go language server, gopls.
labels
Sep 27, 2019
Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.
goplsIssues related to the Go language server, gopls.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.
3 participants
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
we test unified diff output by attempting to apply the patch and seeing if we get the right result, we do this because the actual content of the patch does not matter and may vary, only the results of applying it can be verified to be correct.
because the only way to apply a multi-file patch is to modify the original files, we cannot easily do this in a test (single file mode writes to a different file instead)
we need to consider attempting to copy the files to a temporary directory to apply the patches to test this.
The text was updated successfully, but these errors were encountered: