Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
proposal: testing: Compute benchmark statistics #34626
When a user supplied high
PoC code available in #34479 along with sample output.
The main reason to do this inside
The PoC computes
If this proposal is accepted I can complete the PoC code reasonably fast.
The reason is outlined in the proposal.
The main reason to do this inside go test is the prettyPrint output which causes loss of precision in any tool that computes the statistics based on the output.
But if everybody is happy with this loss, I am fine with the proposal being rejected.
Sorry, I missed that bit from your text. Have you found real scenarios where the loss of precision is a real cause of problems? I've used benchmarks from the scale of nanoseconds to multiple seconds, and I've never really been bothered by the precision. Variance is the usual problem, at least that I've seen.